[#4341] Propagate ProcessingContext to SnapshotStore and Snapshotter#4342
Open
theoema wants to merge 1 commit intoAxonIQ:mainfrom
Open
[#4341] Propagate ProcessingContext to SnapshotStore and Snapshotter#4342theoema wants to merge 1 commit intoAxonIQ:mainfrom
theoema wants to merge 1 commit intoAxonIQ:mainfrom
Conversation
theoema
requested review from
MateuszNaKodach,
hatzlj and
smcvb
and removed request for
a team
- Add @nullable ProcessingContext parameter to SnapshotStore.store() and SnapshotStore.load(), aligned with TokenStore's signature - Add ProcessingContext parameter to Snapshotter.store() and Snapshotter.load() (non-null, internal interface always called from within a processing context) - Pass ProcessingContext through from SnapshottingSourcingHandler to StoreBackedSnapshotter to SnapshotStore - Update InMemorySnapshotStore and AxonServerSnapshotStore implementations - Update StoreBackedSnapshotterTest and StoreBackedSnapshotterTestSuite
theoema
force-pushed
the
feature/snapshot-store-processing-context
branch
from
1e947b6 to
9674ad5
Compare
theoema
changed the title
smcvb
added
Type: Enhancement
Contributor
|
I commented this under the issue, but I'll do it here as well: Moved issue to 5.1.1 with the label under discussion. As John explained, @theoema, there's a chance your suggestion, although perfectly valid when both are kept separate, may no longer be necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4341
Adds
ProcessingContexttoSnapshotStoreandSnapshotterinterfaces, aligning them withEventStoreandTokenStorewhich already receive it.SnapshotStore.store()andload()—@Nullable ProcessingContext, matchingTokenStoreSnapshotter.store()andload()— non-null, internal interface only called fromSnapshottingSourcingHandlerwhich always has a contextSnapshottingSourcingHandlerpasses its existingpcthrough toSnapshotterInMemorySnapshotStore,AxonServerSnapshotStore, and tests