feat(integrationtests): base AbstractIntegrationTest class decoupled from Axon Server#4413
Merged
smcvb merged 7 commits intoaxon-5.1.xfrom Apr 16, 2026
Merged
feat(integrationtests): base AbstractIntegrationTest class decoupled from Axon Server#4413smcvb merged 7 commits intoaxon-5.1.xfrom
smcvb merged 7 commits intoaxon-5.1.xfrom
Conversation
…Axon Server Replace AbstractAxonServerIT and AbstractAxonServerIntegrationTest with an infrastructure-agnostic AbstractIntegrationTest base class backed by a TestInfrastructure strategy interface. AxonServerTestInfrastructure wraps the existing Testcontainers setup; InMemoryTestInfrastructure disables the AxonServer enhancer by FQCN string so the framework's default SimpleCommandBus/InMemoryEventStorageEngine are used without any container dependency. All domain test classes in the administration, student, and course subtrees are made abstract. Each gets a concrete ...AxonServerIT and ...InMemoryIT leaf that pins the infrastructure. CommandPayloadConversionIT remains concrete and AxonServer-only since payload conversion is a distributed-bus concern that has no in-memory equivalent.
…n in AbstractIntegrationTest - less collision risk
…ions to clarify changes
…ions to clarify changes
Merge the abstract createTestInfrastructure() factory and the cached testInfrastructure() accessor into a single abstract testInfrastructure() method. Leaf classes already hold a private static final singleton, so the cache field (and its teardown bookkeeping) was redundant. Rename createConfigurer() to applicationConfigurer() to match the noun-style accessor naming and read more naturally at call sites. Also drop the unused logger field on AbstractIntegrationTest.
MateuszNaKodach
changed the title
…cause it's thrown by `DistirubtedEventBus` only, not by the `SimpleCommandBus`
MateuszNaKodach
added
Type: Feature
MateuszNaKodach
requested review from
abuijze,
hatzlj,
hjohn and
smcvb
and removed request for
a team
|
smcvb
changed the title
smcvb
requested changes
Apr 15, 2026
Contributor
smcvb
left a comment
smcvb
left a comment
There was a problem hiding this comment.
Couple of nits here and there on docs. Biggest pointer is making the abstract test suite classes public, otherwise there's no value in this setup I am afraid. Lastly, it might be good to do a pass through the student, course, and administration domains in this project, to ensure those classes are public as well. I can imagine we may have tests in the future that are specific for Axoniq Framework that require access to the internals too.
| * environments where the connector JAR is absent. | ||
| */ | ||
| private static final String AXON_SERVER_ENHANCER_FQCN = | ||
| "org.axonframework.axonserver.connector.AxonServerConfigurationEnhancer"; |
Contributor
There was a problem hiding this comment.
This should be
Suggested change
| "org.axonframework.axonserver.connector.AxonServerConfigurationEnhancer"; | |
| "io.axoniq.framework.axonserver.connector.configuration.AxonServerConfigurationEnhancer"; |
Contributor
Author
There was a problem hiding this comment.
Not yet @smcvb, because it's still in the repostiory. I'm going to change it after the AxonServer removal form THIS repository, or for the transition period I will disable both.
…refine AxonServer configuration Make integration test classes explicitly `public abstract` for clarity. Enhance documentation with `@author` annotations and refine AxonServer enhancer handling by introducing a transitional constant. Update AxonServer container to use the `latest` tag.
smcvb
approved these changes
Apr 16, 2026
Contributor
smcvb
left a comment
smcvb
left a comment
There was a problem hiding this comment.
My concerns have been addressed, hence I'm approving this pull request.
smcvb
added a commit
that referenced
this pull request
Apr 16, 2026
Remove AxonServer specific integration tests again. With #4413 implemented, the test suites can be implemented differently depending on the available infrastructure. As we're moving Axon Server entirely to Axoniq Framework, any Axon Server versions of the integration tests should be ported entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor the integration test hierarchy in
integrationtests/so that the same domain tests (administration, student, course) run against multiple infrastructure backends. Today every base class (AbstractAxonServerIT,AbstractAxonServerIntegrationTest) hard-codes Axon Server; there is no way to verify the same behavior against the framework's in-memory defaults, and there was no extension point for future event stores ( like Postgres/JDBC/JPA). This PR replaces that coupling with aTestInfrastructurestrategy and a single infrastructure-agnostic base.Changes
Infrastructure layer (new)
testsuite/AbstractIntegrationTest.java— infrastructure-agnostic base replacingAbstractAxonServerIT/AbstractAxonServerIntegrationTest. ExposestestInfrastructure()andapplicationConfigurer()as abstract hooks.createId()usesUUID.randomUUID()to avoid collisions under JUnit'sPER_METHODlifecycle.testsuite/infrastructure/TestInfrastructure.java— strategy withstart()/configureInfrastructure(...)/purgeData()/stop().testsuite/infrastructure/AxonServerTestInfrastructure.java— sharedstatic final AxonServerContainerwithwithReuse(true);stop()is a deliberate no-op (Testcontainers + Ryuk handle JVM-exit cleanup).testsuite/infrastructure/InMemoryTestInfrastructure.java— disables the AxonServer enhancer by FQCN string, notClassreference, so this variant compiles and runs even withoutaxon-server-connectoron the classpath.Domain tests
abstract(5 administration, 10 student, 1 course) with thin...AxonServerIT/...InMemoryITleaf pairs (34 leaves total).CommandPayloadConversionITstays AxonServer-only:SimpleCommandBusdoes not convert payloads, so there is no in-memory equivalent.purgeEventStorage()call sites renamed topurgeData(), now delegated through the infrastructure strategy.Legacy cleanup
AbstractAxonServerITandAbstractAxonServerIntegrationTest.Test assertion fix
MultiEntityCommandHandlingComponentIT/CompoundEntityIdentifierCommandHandlingComponentIT: dropped.isInstanceOf(CommandExecutionException.class)assertions. That wrapper is added by the distributed command bus;SimpleCommandBussurfaces the raw exception. Removing the type check lets the same assertion pass on both backends; the message assertion still validates behavior.