You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The base branch is outdated, we need to rebase it against master to bring in the latest changes.
Also, your CGI module isn’t being used anywhere; the code is still relying on my prototype function in main.rs.
Maybe we could unify everything into the cgi module.
Also, it might make more sense for the cgi module to be part of the standalone server instead of the core library?
If you need any help with the rebase or reorganizing things, feel free to ask!
No problem , I updated my branch feature/cgi
because had a lot of conflicts.
For future reference you could run git rebase master
and it will update your checked branch against master, this could bring some conflicts so you need to fix these manually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.