Skip to content

Copilot/fix luckperms error #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matsu1213 wants to merge 7 commits into from
Closed

Copilot/fix luckperms error #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6dd9186
Initial plan
Copilot Feb 26, 2026
94d1836
Handle duplicate server-name registration in registerPod
Copilot Feb 26, 2026
8cef82b
Reuse existing server lookup in duplicate registration guard
Copilot Feb 26, 2026
ea6b81b
Remove timeout from build job in workflow
matsu1213 Mar 3, 2026
a5d870e
Add Maven Central repository to pom.xml
matsu1213 Mar 3, 2026
9e7b21c
Update Maven repository URL for velocity
matsu1213 Mar 3, 2026
54d1772
Merge branch 'develop/v3' into copilot/fix-luckperms-error
matsu1213 Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ jobs:
if: ${{ github.event_name != 'pull_request' || github.repository != github.event.pull_request.head.repo.full_name }}
name: Build with Java 17
runs-on: ubuntu-latest
timeout-minutes: 10
permissions:
contents: read
steps:
Expand Down
14 changes: 12 additions & 2 deletions src/main/java/net/azisaba/kuvel/KuvelServiceHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,16 @@ public void shutdown() {
* @param serverName The name of the server.
* @return true if the pod is registered successfully.
*/
public boolean registerPod(Pod pod, String serverName) {
public void registerPod(Pod pod, String serverName) {
var currentServer = plugin.getProxy().getServer(serverName);

if (currentServer.isPresent() && podUidAndServerNameMap.getUidFromServerName(serverName) == null) {
plugin
.getLogger()
.warn("Skipped registering server " + serverName + " because the name is already used");
return;
}

String ip = pod.getStatus().getPodIP();
if (ip == null) {
return false;
Expand All @@ -232,8 +241,9 @@ public boolean registerPod(Pod pod, String serverName) {
if (containerPort.isPresent()) {
port = containerPort.get().getContainerPort();
}

InetSocketAddress address = new InetSocketAddress(ip, port);
currentServer.ifPresent(server -> plugin.getProxy().unregisterServer(server.getServerInfo()));
plugin.getProxy().registerServer(new ServerInfo(serverName, address));
podUidAndServerNameMap.register(pod.getMetadata().getUid(), serverName);

Expand Down
Loading