Packaging#148
Open
aman-1004 wants to merge 9 commits intoAzure-Samples:linux-diagnostics-with-packagingfrom
Open
Packaging#148aman-1004 wants to merge 9 commits intoAzure-Samples:linux-diagnostics-with-packagingfrom
aman-1004 wants to merge 9 commits intoAzure-Samples:linux-diagnostics-with-packagingfrom
Conversation
* Created Makefile to generate .deb and .rpm packages for these scripts. * Created single wrapper file to invoke both NFS and CIFS scripts.
* Created Makefile to generate .deb and .rpm packages.
* Created single wrapper file (diag-main.sh) to invoke both
smbclientlogs.sh and nfsclientlogs.sh.
ksub42
reviewed
Jul 4, 2023
| @@ -1,4 +1,4 @@ | |||
| #!/usr/bin/python | |||
Collaborator
There was a problem hiding this comment.
IIRC, Python3 is not available by default on at least some of the distros that we support (RHEL 7?). It might be a better idea to invoke Python as /usr/bin/env python. IIRC the scripts work the same across Python 2 & 3.
ksub42
reviewed
Jul 4, 2023
| @@ -1,4 +1,4 @@ | |||
| #!/usr/bin/python | |||
Collaborator
There was a problem hiding this comment.
Same /usr/bin/env python comment as in trace-nfsbpf.
ksub42
reviewed
Jul 4, 2023
| if [[ $1 == "nfs" ]] || [[ $1 == "cifs" ]]; | ||
| then | ||
| if [[ $1 == "nfs" ]] | ||
| then script_path="${PACKAGE_TREE}/lib/NfsDiagnostics/nfsclientlogs.sh" |
Collaborator
There was a problem hiding this comment.
Nitpick: I'm a little divided about pushing nfsclientlogs (and the smb equivalent) into lib. I figure that since they're executable, they should be under bin. Then again, I also see that having them in lib makes sense. I'm not going to make this a blocker, but I guess it is something we could ask for an opinion about with other folks.
ksub42
requested changes
Jul 4, 2023
Collaborator
ksub42
left a comment
ksub42
left a comment
There was a problem hiding this comment.
Have 2 comments (about the Python invocation). Good to go apart from this.
Collaborator
|
@aman-1004 , can you please update README.? i.e The new steps involved in capturing logs. |
… trace-nfsbpf and trace-cifsbpf scripts.
commit dc391f6 Author: Aman <2020ceb1004@iitrpr.ac.in> Date: Thu Jul 20 03:55:42 2023 +0530 added hooks for shellcheck commit 2f3f3e4 Author: Aman <2020ceb1004@iitrpr.ac.in> Date: Thu Jul 20 03:45:15 2023 +0530 small fix for trace-cifsbpf and trace-nfsbpf scripts commit c4e3d6a Author: Aman <2020ceb1004@iitrpr.ac.in> Date: Thu Jul 20 03:45:03 2023 +0530 small fix for trace-cifsbpf and trace-nfsbpf scripts commit b78153e Author: Aman <2020ceb1004@iitrpr.ac.in> Date: Wed Jul 19 18:49:32 2023 +0530 updated readme file for dependency change commit ea86f74 Author: Aman <2020ceb1004@iitrpr.ac.in> Date: Wed Jul 19 16:02:52 2023 +0530 fixed dep commit commit 6e46116 Author: Aman <2020ceb1004@iitrpr.ac.in> Date: Wed Jul 19 15:24:12 2023 +0530 dependency commit commit ee5346a Author: Aman <2020ceb1004@iitrpr.ac.in> Date: Wed Jul 19 09:14:07 2023 +0530 changed filename to cifs_dmesg from nfs_dmesg within trace-cifsbpf commit 66b4180 Author: Aman <2020ceb1004@iitrpr.ac.in> Date: Tue Jul 18 22:31:41 2023 +0530 demo commit ce28358 Author: Aman <2020ceb1004@iitrpr.ac.in> Date: Tue Jul 18 22:16:27 2023 +0530 demo automatic build commit df4b6b6 Author: Aman <2020ceb1004@iitrpr.ac.in> Date: Mon Jul 10 15:38:34 2023 +0530 random commit af374b7 Author: Aman <2020ceb1004@iitrpr.ac.in> Date: Mon Jul 10 15:37:56 2023 +0530 random commit a0633db Author: Aman <2020ceb1004@iitrpr.ac.in> Date: Mon Jul 10 15:34:47 2023 +0530 random commit 702a029 Author: Aman <2020ceb1004@iitrpr.ac.in> Date: Mon Jul 10 14:25:29 2023 +0530 testing git hooks commit 654e61a Author: Aman <2020ceb1004@iitrpr.ac.in> Date: Mon Jul 10 14:07:37 2023 +0530 random commit 4ddee63 Author: Aman <2020ceb1004@iitrpr.ac.in> Date: Mon Jul 10 13:39:14 2023 +0530 random commit 8faaaad Author: Aman <2020ceb1004@iitrpr.ac.in> Date: Mon Jul 10 13:35:09 2023 +0530 random commit 5e352f7 Author: Aman <2020ceb1004@iitrpr.ac.in> Date: Mon Jul 10 13:31:27 2023 +0530 random commit 739fabe Author: Aman <2020ceb1004@iitrpr.ac.in> Date: Mon Jul 10 13:15:01 2023 +0530 random commit 3bda9fb Author: Aman <2020ceb1004@iitrpr.ac.in> Date: Mon Jul 10 09:11:23 2023 +0530 random commit 25a0e0d Author: Aman <2020ceb1004@iitrpr.ac.in> Date: Mon Jul 10 09:01:41 2023 +0530 random commit 595a9d2 Author: Aman <2020ceb1004@iitrpr.ac.in> Date: Mon Jul 10 09:00:06 2023 +0530 random commit e624c3a Author: Aman <2020ceb1004@iitrpr.ac.in> Date: Mon Jul 10 08:37:48 2023 +0530 random commit 79ac92c Author: Aman <2020ceb1004@iitrpr.ac.in> Date: Mon Jul 10 08:35:36 2023 +0530 _tmp commit 443f5ad Author: Aman <2020ceb1004@iitrpr.ac.in> Date: Mon Jul 10 08:27:48 2023 +0530 testing actions Built an automated setup to build DEP and RPM packages on sucessful push. * Added github hooks to validate scripts before commiting. * Added github action to automatically build the packages on succesful push. * Fixed some minor issues with cifs and nfs diagnostic scripts.
aman-1004
changed the base branch from
master
to
linux-diagnostics-with-packaging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.