Skip to content

Conversation

@StefH
Copy link

@StefH StefH commented Mar 28, 2019

Purpose

  • updated generation code to fix errors and warnings when using Solidity 0.5.2

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
  • Test the code
  1. Start the web-app and press the Generate Code button.
  2. The generated Solidity code should be 0.5.2 compatible

What to Check

Verify that the following are valid

  • memory is used

Other Information

See https://github.com/mstack/bootcamp-blockchain-smartcontracts/tree/master/Lab%205%20(Azure%20Accelerators) for a working example including solidity code and C# example.

@StefH
Copy link
Author

StefH commented Mar 28, 2019

Linked to/from : Azure-Samples/blockchain#151

@cnsegura
Copy link
Contributor

Workbenchbase has been deprecated from the code generator. Can you please remove references to that base class?

@StefH
Copy link
Author

StefH commented Mar 30, 2019

Fixed, please double check

@cnsegura
Copy link
Contributor

cnsegura commented Apr 1, 2019

Thanks StefH, Workbench doesn't yet support Solidity 0.5.x but once it is upgraded we can take these changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants