Add-chat Webpack and ACS SDK Version Update#58
Open
Copennin wants to merge 5 commits intoAzure-Samples:mainfrom
Open
Add-chat Webpack and ACS SDK Version Update#58Copennin wants to merge 5 commits intoAzure-Samples:mainfrom
Copennin wants to merge 5 commits intoAzure-Samples:mainfrom
Conversation
Accidentally committed
RyanHill-MSFT
suggested changes
May 4, 2022
| participants: [ | ||
| { | ||
| id: { communicationUserId: '<USER_ID>' }, | ||
| displayName: '<USER_DISPLAY_NAME>' |
There was a problem hiding this comment.
Add the > back <USER_DISPLAY_NAME
|
MicrosoftDocs/azure-docs#92063 |
RyanHill-MSFT
suggested changes
May 4, 2022
RyanHill-MSFT
left a comment
RyanHill-MSFT
left a comment
There was a problem hiding this comment.
Please see my comment in the review @Copennin
ProbablePrime
approved these changes
May 4, 2022
ProbablePrime
left a comment
ProbablePrime
left a comment
There was a problem hiding this comment.
Good to go, with Ryan's comment resolved.
…ices-javascript-quickstarts into main Fixed formatting issues, removed PII
Author
|
Hi @ProbablePrime, I've made those changes - please let me know if we're good now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
I am updating the add-chat quickstart here to bring it up to the latest versioning that works with webpack. The same needs to be done with our quick start: https://docs.microsoft.com/en-us/azure/communication-services/quickstarts/chat/get-started?msclkid=43feff25c58a11ec85279ab1b8334648&pivots=programming-language-javascript
Currently, if a new user tries to follow our quickstart, as is, they won't be able to run the app as the newer version of webpack does not work as we implemented it, originally.
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
Updates the quickstart to the latest versioning of webpack and our ACS SDKs
Versioning update
How to Test
I've updated the README.md for this-
feel free to consolidate the npm run commands into one.
What to Check
Verify that the following are valid
Other Information