Skip to content

Remove deprecated --include-classic-administrators from Azure CLI command #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Remove deprecated --include-classic-administrators from Azure CLI command #262

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d6f6965
Initial plan
Copilot Nov 21, 2025
101f116
Remove deprecated --include-classic-administrators parameter from Azu…
Copilot Nov 21, 2025
db5ed70
Update comments to reflect removal of classic administrators check
Copilot Nov 21, 2025
3287420
Update role check to look for Owner role instead of Administrator
Copilot Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tools/scripts/AksEdgeAzureSetup/AksEdgeAzureSetup.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,15 +205,15 @@ if ($adminroles) {

if (-not $hasRights) {
# two stage call to work around issue reported here : https://github.com/Azure/azure-powershell/issues/15261 which occurs for CSP subscriptions
# look for classic administrators only when there is no Azure RBAC roles defined
Write-Host "Looking for classic administrator roles"
$adminroles = (az role assignment list --include-classic-administrators) | ConvertFrom-Json
# look for additional role assignments when there are no Azure RBAC roles defined with sufficient privileges
Write-Host "Looking for additional role assignments"
$adminroles = (az role assignment list) | ConvertFrom-Json
$adminrole = $adminroles | Where-Object { $_.principalName -ieq $($session.user.name) }
if ($adminrole) {
Write-Host "Roles enabled for this account are:" -ForegroundColor Cyan
foreach ($role in $adminrole) {
Write-Host "$($role.roleDefinitionName) for scope $($role.scope)" -ForegroundColor Cyan
if (($($role.scope) -eq "/subscriptions/$($aicfg.SubscriptionId)") -and (( $role.roleDefinitionName -match 'Administrator'))) {
if (($($role.scope) -eq "/subscriptions/$($aicfg.SubscriptionId)") -and ($role.roleDefinitionName -match 'Owner')) {
Write-Host "* You have sufficient privileges" -ForegroundColor Green
$hasRights = $true
}
Expand Down