Create cluster w/ 2 node pools, delete cluster by deleting cx rg#4004
Create cluster w/ 2 node pools, delete cluster by deleting cx rg#4004mgahagan73 wants to merge 11 commits intomainfrom
Conversation
mgahagan73
added
ai-assisted
|
/test integration |
|
/test e2e-parallel |
|
/test e2e-parallel |
2 similar comments
|
/test e2e-parallel |
|
/test e2e-parallel |
|
/test stage-e2e-parallel |
|
Currently this job cannot run properly in the pre-merge PR testing environment. Confirmed that it works as expected in stage. Is the best course of action here to label it so it only runs in stage? That way it will not block merge requests in the way we currently run them (MR tests jobs run on INT but with under a dev cluster) At any rate we can probably start reviewing it now. |
|
/test e2e-parallel |
|
/test e2e-parallel |
mbukatov
left a comment
mbukatov
left a comment
There was a problem hiding this comment.
Proposing two changes, otherwise it looks good.
test/e2e/cluster_delete_cx_rg.go
Outdated
| labels.RequireNothing, | ||
| labels.Critical, | ||
| labels.Positive, | ||
| labels.AroRpApiCompatible, |
There was a problem hiding this comment.
This should not have labels.AroRpApiCompatible label, since this use case won't work with sheer ARO RP API only, but relies on ARM integration.
There was a problem hiding this comment.
This means that the first env this test can be executed is INT.
There was a problem hiding this comment.
AroRpApiCompatible removed
There was a problem hiding this comment.
This should run on int, stage and prod but I'll kick off a run on each to double-check.
test/e2e/cluster_delete_cx_rg.go
Outdated
| labels.Critical, | ||
| labels.Positive, | ||
| labels.AroRpApiCompatible, | ||
| labels.TeardownValidation, |
There was a problem hiding this comment.
Also you don't need labels.TeardownValidation, since it was expected to be used with per run cluster tests, after a cluster was deleted.
There was a problem hiding this comment.
TeardownValidation removed
test/e2e/cluster_delete_cx_rg.go
Outdated
| rgClient := tc.GetARMResourcesClientFactoryOrDie(ctx).NewResourceGroupsClient() | ||
| networkClient, err := tc.GetARMNetworkClientFactory(ctx) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| err = framework.DeleteResourceGroup(ctx, rgClient, networkClient, *resourceGroup.Name, false, 45*time.Minute) |
There was a problem hiding this comment.
I just wonder if 45 minutes reasonable timeout for a full deletion.
There was a problem hiding this comment.
That's a good point since we allow 45 minutes for the cluster to be removed through the usual means, I'll add 15 extra minutes.
|
/test stage-e2e-parallel prod-e2e-parallel integration-e2e-parallel |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mgahagan73 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
2 participants
ARO-23928
What
See if we can delete a 2 node pool cluster by deleting the customer resource group.
Why
Special notes for your reviewer