chore: match environment CS config.yaml variable to the ARO-HCP env name#4055
Merged
openshift-merge-bot[bot] merged 1 commit intomainfrom Feb 24, 2026
Merged
Conversation
miguelsorianod
changed the title
miguelsorianod
force-pushed
the
msoriano-change-csconfigyaml-envname-in-devenvs
branch
from
9bd5945 to
aa41927
Compare
miguelsorianod
changed the title
miguelsorianod
force-pushed
the
msoriano-change-csconfigyaml-envname-in-devenvs
branch
from
aa41927 to
4a7d500
Compare
Collaborator
|
/lgtm |
miguelsorianod
force-pushed
the
msoriano-change-csconfigyaml-envname-in-devenvs
branch
from
4a7d500 to
99acb3e
Compare
miguelsorianod
force-pushed
the
msoriano-change-csconfigyaml-envname-in-devenvs
branch
from
99acb3e to
6f9038f
Compare
Collaborator
|
/lgtm |
miguelsorianod
force-pushed
the
msoriano-change-csconfigyaml-envname-in-devenvs
branch
from
6f9038f to
8aa7ad6
Compare
Collaborator
|
/lgtm |
miguelsorianod
force-pushed
the
msoriano-change-csconfigyaml-envname-in-devenvs
branch
from
8aa7ad6 to
a814b7e
Compare
Collaborator
|
/lgtm |
Collaborator
Author
|
/retest |
Collaborator
|
/lgtm |
Collaborator
Author
|
/retest |
1 similar comment
Collaborator
Author
|
/retest |
Collaborator
|
/lgtm |
Collaborator
|
/retest |
4 similar comments
Collaborator
Author
|
/retest |
Collaborator
Author
|
/retest |
Collaborator
Author
|
/retest |
Collaborator
Author
|
/retest |
miguelsorianod
force-pushed
the
msoriano-change-csconfigyaml-envname-in-devenvs
branch
from
dda1dc8 to
0cf0aa6
Compare
Collaborator
|
/lgtm |
Collaborator
Author
|
/retest |
1 similar comment
Collaborator
Author
|
/retest |
Collaborator
|
/lgtm |
Collaborator
Author
|
The failure in https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/Azure_ARO-HCP/4055/pull-ci-Azure-ARO-HCP-main-e2e-parallel/2025936945640640512 is because the e2e verifier in https://github.com/Azure/ARO-HCP/blob/main/test/util/verifiers/kusto.go#L170 assumes that the NamespacePrefix is |
The environment config.yaml variable used by CS had the value of arohcpdev for all dev env based envs. We change it to use the aro-hcp environment key value. The format being arohcp<envname>. This variable value is used by CS to: - Define the Maestro Source ID - As a base for some K8s Names and Namespaces in the Management Cluster In that way we match the ARO-HCP environment name. Changing it has an impact on the ability to see previously existing Maestro resources but the change is performed only on dev envs which are ephemeral. The exception is the shared dev env but in that case no changes occur.
miguelsorianod
force-pushed
the
msoriano-change-csconfigyaml-envname-in-devenvs
branch
from
0cf0aa6 to
463a6d0
Compare
Collaborator
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: geoberle, machi1990, miguelsorianod, raelga The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
Author
|
/retest |
1 similar comment
Collaborator
Author
|
/retest |
openshift-merge-bot
bot
deleted the
msoriano-change-csconfigyaml-envname-in-devenvs
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The environment config.yaml variable used by CS had the value of arohcpdev for all dev env based envs. We change it to use the aro-hcp environment key value. The format being arohcp. This variable value is used by CS to:
In that way we match the ARO-HCP environment name.
Changing it has an impact on the ability to see previously existing Maestro resources but the change is performed only on dev envs which are ephemeral. The exception is the shared dev env but in that case Used by CS to define the maestro s