Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sclarkso The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Skipping CI for Draft Pull Request. |
|
/test e2e-parallel |
|
@roivaz Can you take a look at this change? When I tried to commit it, it said that this file was in the .gitignore, so not sure if this is the correct way of changing this or not? |
| var respErr *azcore.ResponseError | ||
| if errors.As(err, &respErr) && respErr.RawResponse != nil { | ||
| // Extract the Correlation ID header | ||
| corrID := respErr.RawResponse.Header.Get("x-ms-correlation-request-id") | ||
|
|
||
| logger.Error(err, "Failed to delete some resource groups", | ||
| "count", len(resourceGroupsToDelete), | ||
| "correlationID", corrID) | ||
|
|
||
| return fmt.Errorf("cleanup failed (CorrelationID: %s): %w", corrID, err) | ||
| } | ||
|
|
||
| // Fallback for non-Azure errors |
There was a problem hiding this comment.
This won't work as expected. tc.CleanupResourceGroups(..) can return several errors if more than one resource group fails. In that scenario you'd be returning the correlation-id for just one of them. I suggests moving this to the tc.CleanupResourceGroups(..) function so you can add the specific correlation-id for each failed operation.
There was a problem hiding this comment.
I think I've moved it to the correct spot. Thank you.
I see that in the top |
|
/test e2e-parallel |
|
@sclarkso: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
What
add correlationID to error output on cleanup job
Why
frontend was broken in int today and troubleshooting the cleanup job would have been easier with correlationID.
Special notes for your reviewer