Skip to content

Comments

Add kubeevents and systemd logs to must gather output#4166

Open
janboll wants to merge 2 commits intomainfrom
must-gather-additions
Open

Add kubeevents and systemd logs to must gather output#4166
janboll wants to merge 2 commits intomainfrom
must-gather-additions

Conversation

@janboll
Copy link
Collaborator

@janboll janboll commented Feb 20, 2026 •
edited
Loading

What

Add kubeevents and systemd logs to infra log output.
Also address concurrency bug in must-gatherer

Why

Special notes for your reviewer

@openshift-ci openshift-ci bot requested review from deads2k and geoberle February 20, 2026 14:52
@openshift-ci
Copy link

openshift-ci bot commented Feb 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: janboll

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Azure Azure deleted a comment from openshift-ci bot Feb 24, 2026
@sclarkso
Copy link
Collaborator

sclarkso commented Feb 24, 2026

/retest-required

@janboll
Fix concurrency in must-gather code
b35f41e 
Errors could cause deadlocks in must-gather code. Reason was missing
handling of context cancelations and lack of error fetching. This
refactoring now introduces the missing concepts.
@janboll janboll force-pushed the must-gather-additions branch from 2786b84 to b35f41e Compare February 24, 2026 10:08
@openshift-ci
Copy link

openshift-ci bot commented Feb 24, 2026

@janboll: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/lint b35f41e link true /test lint
ci/prow/e2e-parallel b35f41e link true /test e2e-parallel

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@geoberle geoberle Awaiting requested review from geoberle

Assignees

No one assigned

Labels

approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@janboll @sclarkso