Skip to content

Switch kube-webhook-certgen from mutable tag to SHA digest#4184

Merged
openshift-merge-bot[bot] merged 2 commits intomainfrom
fix-admission-webhook
Feb 24, 2026
Merged

Switch kube-webhook-certgen from mutable tag to SHA digest#4184
openshift-merge-bot[bot] merged 2 commits intomainfrom
fix-admission-webhook

Conversation

@hbhushan3
Copy link
Collaborator

@hbhushan3 hbhushan3 commented Feb 23, 2026

https://issues.redhat.com/browse/AROSLSRE-492
Replaces #4178

Updates the kube-webhook-certgen (ingress-nginx admission webhook) image to be managed by the image-updater, pinning it by SHA digest instead of a mutable tag.

Changes

  • tooling/image-updater/config.yaml — Added kube-webhook-certgen entry with correct jsonPaths targeting defaults.svc.prometheus and defaults.mgmt.prometheus
  • config/config.yaml — Replaced tag field with sha for the admissionWebhook patch image in both svc and mgmt prometheus sections
  • config/config.schema.json — Updated admissionWebhook patch image schema to use $ref: containerImageSha instead of an inline schema with tag
  • observability/prometheus/values-svc.yaml — Changed template reference from .tag to .sha
  • observability/prometheus/values-mgmt.yaml — Changed template reference from .tag to .sha
  • Ran make -C config materialize as a sperate commit

@openshift-ci openshift-ci bot requested review from geoberle and janboll February 23, 2026 20:58
@hbhushan3 hbhushan3 force-pushed the fix-admission-webhook branch from 9c85eaf to a7ade8f Compare February 23, 2026 21:49
@avollmer-redhat
Copy link
Collaborator

/lgtm

@avollmer-redhat
Copy link
Collaborator

/remove-lgtm

@openshift-ci openshift-ci bot removed the lgtm label Feb 23, 2026
@avollmer-redhat
Copy link
Collaborator

If you use the acr path to look for new images, new versions will never be found to pull through to acr. Doesn't your image updater need to look at the latest upstream first, so the new image can be pulled through the pull through cache and into acr?

@hbhushan3 hbhushan3 force-pushed the fix-admission-webhook branch from a7ade8f to ce78feb Compare February 24, 2026 00:10
@avollmer-redhat
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 24, 2026
@janboll
Copy link
Collaborator

janboll commented Feb 24, 2026

/approve

@janboll janboll closed this Feb 24, 2026
@janboll janboll reopened this Feb 24, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 24, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avollmer-redhat, hbhushan3, janboll

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sajeelirkal
Copy link

/test integration

@hbhushan3
Copy link
Collaborator Author

/test e2e-parallel

@openshift-merge-bot openshift-merge-bot bot merged commit 02acbb8 into main Feb 24, 2026
32 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the fix-admission-webhook branch February 24, 2026 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants