Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbarnes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This adds operation controllers to monitor asynchronous create, update, and delete operations for node pool and external auth resource types and removes this logic from OperationsScanner. Although it's dead code now, I left operations_scanner.go in place because there's a good deal of metrics code there that we need to decide whether to adapt to the operation controlers or discard. There was some debate about whether the current backend metrics are actually useful; tracking CS polling success rate rather than async operation success rate.
mbarnes
force-pushed
the
1p/more-operation-controllers
branch
from
7944a87 to
2330255
Compare
| newOperationStatus := arm.ProvisioningStateSucceeded | ||
| logger.Info("new status", "newStatus", newOperationStatus) |
There was a problem hiding this comment.
This looked odd to me, but it's what the old operation scanner code had. At the time it was initially written, CS must not have offered a status field for ExternalAuth. In working on this I realized that's since been added but I wasn't made aware.
This PR is a straight move of the old code. I'll defer actually checking ExternalAuth status to a follow-up PR.
|
/test e2e-parallel |
|
@mbarnes: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Related to ARO-24384 - Move Cluster Service CRUD calls to ARO-HCP backend
What
This adds operation controllers to monitor asynchronous create, update, and delete operations for node pool and external auth resource types and removes this logic from OperationScanner.
Although it's dead code now, I left
operations_scanner.goin place because there's a good deal of metrics code there that we need to decide whether to adapt to the operation controllers or discard.There was some debate about whether the OperationScanner metrics were actually useful, since they really just tracked CS polling success rate rather than async operation success rate.
Why
This is a preliminary step toward getting Cluster Service calls moved to a new backend controller.
Special notes for your reviewer