fix: add --allow-change-held-packages to node bootstrap script#53
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the node bootstrap script variant template to tolerate APT “held” packages during installation, aligning generated scripts and their tests with this new behavior.
Changes:
- Add
--allow-change-held-packagesto theapt-get installcommand in the node bootstrap script template. - Update the script marshaling unit test to assert the new install command output.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cli/internal/config/nodebootstrap/assets/script.sh.tmpl | Adds the APT flag to prevent install failures when target packages are held. |
| cli/internal/config/nodebootstrap/script_test.go | Updates expected output strings to match the new rendered script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
bcho
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--allow-change-held-packagesflag toapt-get installin the node bootstrap script template, fixing package installation failures when Kubernetes packages (kubelet, kubectl, etc.) are held at a specific version.Changes
cli/internal/config/nodebootstrap/assets/script.sh.tmpl— add--allow-change-held-packagesto the apt-get install commandcli/internal/config/nodebootstrap/script_test.go— update test expectation to include the new flag