Added template for executing query on recurrence#6
Open
shahparth-lab wants to merge 4 commits intomasterfrom
Open
Added template for executing query on recurrence#6shahparth-lab wants to merge 4 commits intomasterfrom
shahparth-lab wants to merge 4 commits intomasterfrom
Conversation
…g the UI which executes a query and sends results on recurrence
derek1ee
reviewed
Apr 27, 2021
| @@ -0,0 +1,305 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
I think you also need to update the manifest.json file to include this template.
derek1ee
reviewed
Apr 28, 2021
| { | ||
| "id": "execute-query-send-result", | ||
| "title": "execute-query-send-result", | ||
| "description": "Executes and sends you the query results on recurrence", |
Contributor
There was a problem hiding this comment.
I don't think we address customers as "you", maybe something like "Executes and send query result via e-mail on schedule."
derek1ee
suggested changes
Apr 28, 2021
| @@ -0,0 +1,305 @@ | |||
| { | |||
| "id": "execute-query-send-result", | |||
| "title": "execute-query-send-result", | |||
| } | ||
| }, | ||
| "method": "post", | ||
| "path": "/v2/datasets/@{encodeURIComponent(encodeURIComponent('sql-server-tasks.database.windows.net'))},@{encodeURIComponent(encodeURIComponent('sql-sample-tasks'))}/query/sql" |
Contributor
There was a problem hiding this comment.
looks like database/server isn't parameterized.
| "inputs": { | ||
| "body": { | ||
| "Body": "<p>@{body('ExecuteQuery')?['resultsets']}<br>\n<br>\n<br>\n<br>\n<br>\n<br>\n</p>", | ||
| "Subject": "Query results from ", |
Contributor
There was a problem hiding this comment.
Subject/To not parameterized.
| "supportedResources": [ | ||
| "Microsoft.Sql/servers/databases" | ||
| ], | ||
| "excludeResources": [ |
| "office365": { | ||
| "connectionId": "", | ||
| "connectionName": "", | ||
| "id": "/subscriptions/80d4fe69-c95b-4dd2-a938-9250f1c8ab03/providers/Microsoft.Web/locations/westus/managedApis/office365" |
Contributor
There was a problem hiding this comment.
Should remove hardcoded sub id here and on line 293
Contributor
|
Please update the template data model before making this checkin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.