Fix required+readonly properties incorrectly included in initialization constructors

[Copilot]

Description

Properties marked @visibility(Lifecycle.Read) that are also required were incorrectly included in public initialization constructors. These should only appear in internal serialization constructors.

Changes Made

Modified SchemaObjectType.BuildInitializationConstructor() in src/AutoRest.CSharp/Common/Output/Models/Types/SchemaObjectType.cs to exclude required+readonly properties from initialization constructor parameters:

// Before
else if (IsStruct || property.InputModelProperty?.IsRequired == true)

// After  
else if ((IsStruct || property.InputModelProperty?.IsRequired == true) && property.InputModelProperty?.IsReadOnly != true)

Removed incorrectly committed temporary files from test/TestProjects/MgmtTypeSpec/tsp-output/@azure-tools/typespec-csharp/ that were added during development.

Example

Given this TypeSpec model:

model Foo {
  a: string;                        // required
  b?: string;                       // optional
  @visibility(Lifecycle.Read)
  c: string;                        // required + readonly
  @visibility(Lifecycle.Read)
  d?: string;                       // optional + readonly
}

Before: public Foo(string a, string c) {}
After: public Foo(string a) {}

Required+readonly properties remain in the internal serialization constructor for deserialization.

Validation

• Verified with existing test case RoundTripModel in FirstTest-TypeSpec which has required+readonly properties that are correctly excluded from the public constructor
• Regenerated test projects to confirm no additional code changes needed
• All existing tests pass

Fixes #5423

Checklist

To ensure a quick review and merge, please ensure:

• The PR has a understandable title and description explaining the why and what.
• The PR is opened in draft if not ready for review yet.
  • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
• The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

• Build is completely green
  • Submissions with test failures require tracking issue and approval of a CODEOWNER
• At least one +1 review by a CODEOWNER
• All -1 reviews are confirmed resolved by the reviewer
  • Override/Marking reviews stale must be discussed with CODEOWNERS first

Original prompt

---

This section details on the original issue you should resolve

<issue_title>[Bug] Models in mgmt plane would generate "required+readonly" properties into its public ctor</issue_title>
<issue_description>if we have this model:

model Foo
{
  a: string;
  b?: string;
  @visibility(Lifecycle.Read)
  c: string;
  @visibility(Lifecycle.Read)
  d?: string;
}

the correct behavior is that, we generate this csharp class:

public partial class Foo
{
    public Foo(string a) {}
}

but in fact, this generates the following:

public partial class Foo
{
    public Foo(string a, string c) {}
}

which is incorrect.
</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes [Bug] Models in mgmt plane would generate "required+readonly" properties into its public ctor #5423

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[ArcturusZhang]

I think these files are incorrectly generated.
We should remove it.

[Copilot]

Removed in commit 66575ab.

[ArcturusZhang]

same here, we should remove this file.

[Copilot]

Removed in commit 66575ab.

[ArcturusZhang]

@copilot I think your change is fine, but please run ./eng/Generate.ps1 to regenerate all the test projects.

[Copilot]

@copilot I think your change is fine, but please run ./eng/Generate.ps1 to regenerate all the test projects.

I regenerated test projects to verify. The generated code is already correct - no changes were needed. The fix ensures required+readonly properties are excluded from initialization constructors as expected. Verified with FirstTest-TypeSpec which has readOnlyRequiredRecordUnknown property.