Auto PR for https://github.com/microsoft/typespec/pull/5270#2947
Closed
Auto PR for https://github.com/microsoft/typespec/pull/5270#2947
Conversation
msyyc
commented
Dec 6, 2024
| if response.status_code == 400: | ||
| error = self._deserialize.failsafe_deserialize(str, pipeline_response) | ||
| elif response.status_code == 404: | ||
| error = self._deserialize.failsafe_deserialize(_models.NotFoundErrorBase, pipeline_response) |
Member
Author
There was a problem hiding this comment.
Suggested change
| error = self._deserialize.failsafe_deserialize(_models.NotFoundErrorBase, pipeline_response) | |
| error = self._deserialize.failsafe_deserialize(_models.NotFoundErrorBase, response) |
I think it shall be response instead of pipeline_response here.
msyyc
commented
Dec 6, 2024
| map_error(status_code=response.status_code, response=response, error_map=error_map) | ||
| error = None | ||
| if response.status_code == 400: | ||
| error = self._deserialize.failsafe_deserialize(str, pipeline_response) |
Member
Author
There was a problem hiding this comment.
Why the deserialize type is str here for 400 while int for 501?
msyyc
commented
Dec 6, 2024
| error = self._deserialize.failsafe_deserialize(_models.NotFoundErrorBase, pipeline_response) | ||
| elif response.status_code == 501: | ||
| error = self._deserialize.failsafe_deserialize(int, pipeline_response) | ||
| raise HttpResponseError(response=response, model=error) |
Member
Author
There was a problem hiding this comment.
For 404, old code raise ResourceNotFoundError while new logic always raise HttpResponseError.
msyyc
commented
Dec 6, 2024
| raise HttpResponseError(response=response) | ||
| map_error(status_code=response.status_code, response=response, error_map=error_map) | ||
| error = None | ||
| if response.status_code == 400: |
Member
Author
There was a problem hiding this comment.
For 400/501, failsafe_deserialize will always return None so maybe we don't need the logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto PR for microsoft/typespec#5270