Resource mode: Support --recursive, --include-resource-group
#643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the resource mode to make an additional get call to validate the specified resource exists, instead of being marked as errored resource at a later point (from the provider). This makes sense for the resource mode since these resources are specified explicitly by the users, so if they don't exist, shall fail fast.
The benefit of this additional call is that it brings all the features from
azlist, including the already exposed ones like--include-role-assignment. This PR extends the features to also include--recursive,--include-resource-group.Now with a RG, which contains a vnet, which contains a subnet can be exported together with:
aztfy res -r --include-resource-group <vnet-id>. Whilst,aztfy res -r <rg-id>only returns the resource group, since the--recursiveonly returns the direct child resources.After: #642