chore: update to go1.24 #3912
Open
chore: update to go1.24 #3912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpayne3506
requested review from
QxBytes,
santhoshmprabhu,
camrynl,
rbtr,
ZetaoZhuang,
a team,
paulyufan2,
ashvindeodhar and
thatmattlong
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the Go runtime from version 1.23 to 1.24.0 across the Azure Container Networking project. It consolidates tool management by moving from separate tool binaries to leveraging Go 1.24's built-in tool support and removes several obsolete toolbox components.
- Upgrades Go version from 1.23.x to 1.24.0 across all modules and Docker images
- Refactors tool management to use
go toolcommands instead of separate binary builds - Removes deprecated toolbox server and manifest files
Reviewed Changes
Copilot reviewed 46 out of 50 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod, zapai/go.mod, dropgz/go.mod, etc. | Update Go version to 1.24.0 and related dependency versions |
| tools.go.mod | Restructure from traditional require statements to Go 1.24's tool directive |
| Makefile, platform/Makefile, various CRD Makefiles | Replace tool binary paths with go tool commands |
| Dockerfiles | Update base Go images to 1.24 versions with new SHA digests |
| hack/toolbox/* | Remove deprecated toolbox server implementation and manifests |
| GitHub workflows | Update to use go-version-file instead of hardcoded versions |
jpayne3506
force-pushed
the
jpayne/go1.24
branch
11 times, most recently
from
2dff178 to
a507f8c
Compare
rbtr
reviewed
Aug 8, 2025
rbtr
reviewed
Aug 8, 2025
jpayne3506
force-pushed
the
jpayne/go1.24
branch
from
e769fca to
2fd7b43
Compare
|
Azure Pipelines successfully started running 2 pipeline(s). |
QxBytes
previously approved these changes
Aug 11, 2025
rayaisaiah
previously approved these changes
Aug 12, 2025
camrynl
previously approved these changes
Aug 12, 2025
jpayne3506
dismissed stale reviews from camrynl, rayaisaiah, and QxBytes
via
594cfde
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
jpayne3506
force-pushed
the
jpayne/go1.24
branch
from
594cfde to
d0cef8f
Compare
|
https://github.com/Azure/azure-container-networking/actions/runs/16919035614/job/47940263622?pr=3912 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Takes on intent from #3467 and rebases it with new changes, notably
make dockerfileswhich leveragesrenderkitAdditionally:
go tools -modfile=tools.go.mod controller-gen ...make regenerate-crdto matchmake dockerfilesinteraction with GH workflow*printfusages - https://pkg.go.dev/golang.org/x/tools/go/analysis/passes/printf#hdr-ExamplesIssue Fixed:
Requirements:
Notes: