Expanding mtpnc status to include delete status

[shreyashastantram]

Reason for Change:

Issue Fixed:

Requirements:

• uses conventional commit messages
• includes documentation
• adds unit tests
• relevant PR labels added

Notes:

[Copilot]

Pull Request Overview

Expands MultitenantPodNetworkConfig visibility and lifecycle status tracking.

• Adds PodUID and Status printer columns; removes PodNetwork printer column.
• Introduces new MTPNCStatusDeleting status constant.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
crd/multitenancy/manifests/multitenancy.acn.azure.com_multitenantpodnetworkconfigs.yaml	Adjusts CRD printer columns to include PodUID and Status, removes PodNetwork.
crd/multitenancy/api/v1alpha1/multitenantpodnetworkconfig.go	Adds PodUID and Status printcolumn annotations and new Deleting status constant.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

[nitpick] The new status MTPNCStatusDeleting is introduced without accompanying documentation on when it is set or how controllers should transition from/to it. Please add a brief comment above the status constants explaining each status, especially Deleting (e.g., whether it indicates a finalizer in progress, resource cleanup, or a terminal state).

[rbtr]

i think copilot is on to something here.
adding a deleted status seems risky. what sets it? if i do a kubectl delete ... i'm not setting that status. so there's an opportunity for anything which uses this status to learn that the mtpnc is deleting to miss that

[miguelgoms]

this would be set by dnc-rc as the mtpnc finalizer - we can document the semantics here.

[rbtr]

yes, but what if it doesn't? this can't be anything more than advisory, because if you depend on it you can miss it because it's not actually hardlinked to the object being deleted.

[shreyashastantram]

we are not taking any programmatic dependency on it, we don't want mtpnc to have ready state while it's actually getting deleted.