LRP negative test

[karina-ranadive]

Reason for Change:

Issue Fixed:

Requirements:

• uses conventional commit messages
• includes documentation
• adds unit tests
• relevant PR labels added

Notes:

[Copilot]

Pull Request Overview

Adds negative Local Redirect Policy (LRP) test scenarios and parameterizes Prometheus endpoint usage in existing LRP tests.

• Extends testLRPCase to accept a Prometheus address for flexible metric validation.
• Introduces comprehensive negative and resilience LRP tests (resource recreation, pod restarts, cilium validation).
• Adds helper functions for validating Cilium LRP state and recreating test resources.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
test/integration/lrp/lrp_test.go	Adds negative LRP test flow, Prometheus address parameter, and Cilium/LRP validation helpers.
test/integration/lrp/lrp_fqdn_test.go	Updates calls to testLRPCase to include the new Prometheus address parameter.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The testify assertions use formatted messages with placeholders but require.Greater and require.Equal do not perform format substitution; use require.Greaterf / require.Equalf or pre-format the message with fmt.Sprintf to ensure values appear in failure output.

Suggested change

	require.Equal(t, afterValue, beforeValue, "dns metric count increased after command - before: %.0f, after: %.0f", beforeValue, afterValue)
	require.Equalf(t, afterValue, beforeValue, "dns metric count increased after command - before: %.0f, after: %.0f", beforeValue, afterValue)

[Copilot]

Fixed sleep introduces unnecessary delay and potential flakiness; replace with a poll-based wait (e.g., repeatedly checking for resource absence/recreation with a timeout) to reduce test duration and improve reliability.

Suggested change

	// Wait for deletion to complete
	time.Sleep(10 * time.Second)
	// Wait for deletion to complete (poll for absence of client DaemonSet and LRP)
	retry.DoWithTimeout(ctx, "wait for client DaemonSet deletion", 30*time.Second, func(ctx context.Context) (bool, error) {
	_, err := dsClient.Get(ctx, clientDS.Name, metav1.GetOptions{})
	if err != nil {
	// DaemonSet not found
	return true, nil
	}
	// Still exists
	return false, nil
	})
	retry.DoWithTimeout(ctx, "wait for LRP deletion", 30*time.Second, func(ctx context.Context) (bool, error) {
	_, err := lrpClient.Get(ctx, lrp.Name, metav1.GetOptions{})
	if err != nil {
	// LRP not found
	return true, nil
	}
	// Still exists
	return false, nil
	})