Remove PnP specific tests, exclude some dependencies from our iot-service-client test dependency#1819
Open
timtay-microsoft wants to merge 2 commits intomainfrom
Open
Remove PnP specific tests, exclude some dependencies from our iot-service-client test dependency#1819timtay-microsoft wants to merge 2 commits intomainfrom
timtay-microsoft wants to merge 2 commits intomainfrom
Conversation
…vice-client test dependency The com.microsoft.rest.client-runtime dependency we get transitively from iot-service-client is no longer compatible with the latest + secure dependencies, so we need to exclude it from our test dependency. The only place it was being used was in these legacy pnp tests + samples which are no longer relevant
timtay-microsoft
requested review from
avishekpant,
maximsemenov80 and
olivakar
as code owners
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The com.microsoft.rest.client-runtime dependency we get transitively from the iot-service-client package is no longer compatible with the latest + secure version of some shared dependencies, so we need to exclude it.
The only place it was being used was in these legacy pnp tests + samples which are no longer relevant and can safely be added back later if needed. This would require a service client package with these digital twin APIs without this client-runtime dependency, though