[PS] Migrate MonitorWorkspace in Monitor module to autorest v4 #28186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
JoyerJin
changed the title
JoyerJin
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the MonitorWorkspace module in the Monitor package from AutoRest v3 to AutoRest v4, which involves updating the code generation configuration and updating related documentation and breaking change exceptions.
- Updates AutoRest configuration to use v4 default instead of explicitly using v3 extension
- Adds new parameter sets for JSON file and string input to workspace cmdlets
- Updates documentation to reflect the new cmdlet capabilities and output types
Reviewed Changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/StaticAnalysis/Exceptions/Az.Monitor/BreakingChangeIssues.csv | Documents breaking changes from v3 to v4 migration for property types and parameter sets |
| src/Monitor/MonitorWorkspace.Autorest/README.md | Updates AutoRest configuration to remove v3 extension and modify variant removal directive |
| src/Monitor/MonitorWorkspace.Autorest/docs/*.md | Updates cmdlet documentation with new parameter sets and simplified output types |
| src/Monitor/Monitor/help/*.md | Updates help documentation to match the autorest module changes |
| src/Monitor/MonitorWorkspace.Autorest/test/env.json | Updates test environment configuration with new resource identifiers |
| src/Monitor/Monitor.sln | Updates solution file with new project GUID for the regenerated module |
| # For new modules, please avoid setting 3.x using the use-extension method and instead, use 4.x as the default option | ||
| use-extension: | ||
| "@autorest/powershell": "3.x" | ||
|
|
||
| directive: | ||
| - where: | ||
| subject: ^AzureMonitorWorkspace(.*) | ||
| set: | ||
| subject: $1 | ||
| - where: |
There was a problem hiding this comment.
The regex pattern uses a negative lookahead that may be difficult to understand. Consider adding a comment explaining that this removes Create/Update variants except for Expanded, JsonFilePath, and JsonString variants.
Suggested change
| - where: | |
| - where: | |
| # Remove Create/Update variants unless they are Expanded, JsonFilePath, or JsonString |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.