Skip to content

Improve test coverage and add condition for getting GitHub PAT #28226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 21, 2025

Conversation

vidai-msft
Copy link
Contributor

Description

This PR fixes issue when CIPlan does not exist and improve the test coverage steps by introducing condition when getting GitHub PAT.

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings July 18, 2025 09:37
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the test coverage pipeline by adding conditional execution logic for retrieving GitHub PAT tokens. The changes ensure that the GitHub PAT is only retrieved when actually needed, specifically when updating test coverage baselines.

  • Added conditional execution parameter to the GitHub PAT retrieval template
  • Updated test coverage pipeline to only get GitHub PAT when updating baselines
  • Reorganized YAML structure for better readability

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
.azure-pipelines/util/get-github-pat-steps.yml Added conditional execution parameter and improved task organization
.azure-pipelines/test-coverage.yml Updated to conditionally execute GitHub PAT retrieval only when updating baselines

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@YanaXu YanaXu merged commit ca07e18 into Azure:main Jul 21, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants