[Az.ServiceFabric] Set-AzServiceFabricManagedNodeType: Add parameter -VmSize
#28230
+16,003
−198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for in-place sku swap
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new -VmSize parameter to the Set-AzServiceFabricManagedNodeType cmdlet to enable in-place SKU changes for Service Fabric managed node types.
Key changes:
- Added
-VmSizeparameter to allow updating the virtual machine size of existing node types - Implemented proper parameter validation and documentation
- Added comprehensive test coverage for the new functionality
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| SetAzServiceFabricManagedNodeType.cs | Added VmSize parameter and implementation logic to update node type VM size |
| Set-AzServiceFabricManagedNodeType.md | Updated cmdlet documentation to include the new VmSize parameter |
| ChangeLog.md | Added changelog entry documenting the new VmSize parameter |
| ServiceFabricManagedClustersTests.ps1 | Added new test function to verify VmSize change functionality |
| ServiceFabricManagedClustersTests.cs | Added test method to run the VmSize change test |
...Fabric/ServiceFabric/Commands/ManagedClusters/NodeTypes/SetAzServiceFabricManagedNodeType.cs
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
YanaXu
reviewed
Jul 21, 2025
| @@ -374,6 +392,22 @@ Accept pipeline input: True (ByValue) | |||
| Accept wildcard characters: False | |||
| ``` | |||
|
|
|||
| ### -VmSize | |||
There was a problem hiding this comment.
Please only keep this help md file and revert all other help files' change.
There was a problem hiding this comment.
Will do. Should I make a seperate PR to update the other help files?
There was a problem hiding this comment.
Why to update other help files? I think you only update one cmdlet, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set-AzServiceFabricManagedNodeType: Add parameter-VmSizeto allow for in-place sku swapMandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.