Skip to content

Update PSApplicationGatewayFirewallPolicyManagedRuleOverride and PSAp… #28549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Update PSApplicationGatewayFirewallPolicyManagedRuleOverride and PSAp… #28549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Network/Network/Models/PSApplicationGatewayFirewallPolicyManagedRuleOverride.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,8 @@ public partial class PSApplicationGatewayFirewallPolicyManagedRuleOverride

[Ps1Xml(Target = ViewControl.Table)]
public string Sensitivity { get; set; }

[Ps1Xml(Target = ViewControl.Table)]
public string ParanoiaLevel { get; set; }
}
}
2 changes: 2 additions & 0 deletions src/Network/Network/Models/PSApplicationGatewayFirewallPolicyManagedRuleSet.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ public partial class PSApplicationGatewayFirewallPolicyManagedRuleSet
[Ps1Xml(Target = ViewControl.Table)]
public string RuleSetVersion { get; set; }
[Ps1Xml(Target = ViewControl.Table)]
public string DisplayName { get; private set; }
Copy link
Preview

Copilot AI Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DisplayName property has a private setter which makes it read-only from external code. Consider whether this property should allow external modification or if there should be a constructor parameter or internal method to set this value. Without a way to populate this property, it will always be null.

Copilot uses AI. Check for mistakes.

[Ps1Xml(Target = ViewControl.Table)]
public List<PSApplicationGatewayFirewallPolicyManagedRuleGroupOverride> RuleGroupOverrides { get; set; }
[Ps1Xml(Target = ViewControl.Table)]
public List<PSApplicationGatewayFirewallPolicyManagedRuleSetRuleGroup> ComputedDisabledRules { get; private set; }
Expand Down