Skip to content

Conversation

Y-Sindo
Copy link
Member

@Y-Sindo Y-Sindo commented Sep 12, 2025

Description

Support configuring custom certificate, custom domain and managed identity for SignalR Service

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings September 12, 2025 08:11
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for custom domains and certificates as well as managed identities for SignalR Service. The changes include both hand-written PowerShell cmdlets for classic SignalR service and auto-generated cmdlets for the newer WebPubSub service.

  • Adds new custom certificate and custom domain management cmdlets for SignalR service (New, Get, Remove, Update operations)
  • Adds managed identity support for SignalR service creation and updates with both system-assigned and user-assigned identity options
  • Updates help documentation and regenerates help files for new and existing cmdlets with the ProgressAction parameter

Reviewed Changes

Copilot reviewed 56 out of 163 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
src/SignalR/SignalR/help/*.md Regenerated help files with ProgressAction parameter and new cmdlet documentation
src/SignalR/SignalR/Cmdlets/*CustomDomain*.cs New cmdlets for managing custom domains (New, Get, Remove, Update)
src/SignalR/SignalR/Cmdlets/*CustomCertificate*.cs New cmdlets for managing custom certificates (New, Get, Remove)
src/SignalR/SignalR/Cmdlets/NewAzureRmSignalR.cs Added managed identity support with CreateManagedIdentity method
src/SignalR/SignalR/Cmdlets/UpdateAzureRmSignalR.cs Added managed identity update support with UpdateManagedIdentity method
src/SignalR/SignalR/Models/*.cs New model classes for managed identity, custom certificates, and custom domains
src/SignalR/SignalR/Utilities/Constants.cs Added resource type constants for custom domain and certificate child resources
src/SignalR/SignalR.Test/ScenarioTests/*.ps1/*.cs New test scenarios for custom certificate and domain functionality

Copy link
Preview

Copilot AI Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ProgressAction parameter documentation contains placeholder text '{{ Fill ProgressAction Description }}' instead of a proper description. This should be replaced with appropriate documentation describing what the ProgressAction parameter does.

Suggested change
{{ Fill ProgressAction Description }}
Specifies how the cmdlet responds to progress updates. You can use this parameter to control whether progress information is displayed, suppressed, or handled in a specific way during execution.

Copilot uses AI. Check for mistakes.

Copy link
Preview

Copilot AI Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ProgressAction parameter documentation contains placeholder text '{{ Fill ProgressAction Description }}' instead of a proper description. This should be replaced with appropriate documentation describing what the ProgressAction parameter does.

Suggested change
{{ Fill ProgressAction Description }}
Specifies how the cmdlet responds to progress updates. The acceptable values for this parameter are: Continue, SilentlyContinue, Stop, Suspend, and Inquire. The default value is None.

Copilot uses AI. Check for mistakes.

Copy link
Preview

Copilot AI Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ProgressAction parameter documentation contains placeholder text '{{ Fill ProgressAction Description }}' instead of a proper description. This should be replaced with appropriate documentation describing what the ProgressAction parameter does.

Suggested change
{{ Fill ProgressAction Description }}
Specifies how the cmdlet responds to progress updates. The acceptable values for this parameter are: Continue, SilentlyContinue, Stop, and Inquire.

Copilot uses AI. Check for mistakes.

```
### -ProgressAction
{{ Fill ProgressAction Description }}
Copy link
Preview

Copilot AI Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ProgressAction parameter documentation contains placeholder text '{{ Fill ProgressAction Description }}' instead of a proper description. This should be replaced with appropriate documentation describing what the ProgressAction parameter does.

Suggested change
{{ Fill ProgressAction Description }}
Specifies how the cmdlet responds to progress updates. The acceptable values for this parameter are: Continue, SilentlyContinue, Stop, Suspend, and Inquire.

Copilot uses AI. Check for mistakes.

```
### -ProgressAction
{{ Fill ProgressAction Description }}
Copy link
Preview

Copilot AI Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ProgressAction parameter documentation contains placeholder text '{{ Fill ProgressAction Description }}' instead of a proper description. This should be replaced with appropriate documentation describing what the ProgressAction parameter does.

Suggested change
{{ Fill ProgressAction Description }}
Specifies how the cmdlet responds to a progress update event. The acceptable values for this parameter are: Continue, SilentlyContinue, Stop, Suspend, and Inquire. By default, progress is displayed in the console.

Copilot uses AI. Check for mistakes.

```
### -ProgressAction
{{ Fill ProgressAction Description }}
Copy link
Preview

Copilot AI Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ProgressAction parameter documentation contains placeholder text '{{ Fill ProgressAction Description }}' instead of a proper description. This should be replaced with appropriate documentation describing what the ProgressAction parameter does.

Suggested change
{{ Fill ProgressAction Description }}
Specifies how the cmdlet responds to progress updates. The acceptable values for this parameter are: Continue, SilentlyContinue, Stop, Suspend, and Inquire.

Copilot uses AI. Check for mistakes.

```
### -ProgressAction
{{ Fill ProgressAction Description }}
Copy link
Preview

Copilot AI Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ProgressAction parameter documentation contains placeholder text '{{ Fill ProgressAction Description }}' instead of a proper description. This should be replaced with appropriate documentation describing what the ProgressAction parameter does.

Suggested change
{{ Fill ProgressAction Description }}
Specifies how the cmdlet responds to progress updates. The acceptable values for this parameter are: Continue, SilentlyContinue, Stop, Suspend, and Inquire.

Copilot uses AI. Check for mistakes.

```
### -ProgressAction
{{ Fill ProgressAction Description }}
Copy link
Preview

Copilot AI Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ProgressAction parameter documentation contains placeholder text '{{ Fill ProgressAction Description }}' instead of a proper description. This should be replaced with appropriate documentation describing what the ProgressAction parameter does.

Suggested change
{{ Fill ProgressAction Description }}
Specifies how the cmdlet responds to progress updates. The acceptable values for this parameter are: Continue, SilentlyContinue, Stop, and Inquire.

Copilot uses AI. Check for mistakes.

```
### -ProgressAction
{{ Fill ProgressAction Description }}
Copy link
Preview

Copilot AI Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ProgressAction parameter documentation contains placeholder text '{{ Fill ProgressAction Description }}' instead of a proper description. This should be replaced with appropriate documentation describing what the ProgressAction parameter does.

Suggested change
{{ Fill ProgressAction Description }}
Specifies how progress updates are displayed during the execution of the cmdlet. You can use this parameter to control whether progress information is shown, hidden, or handled in a specific way.

Copilot uses AI. Check for mistakes.

@isra-fel
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly self-assigned this Sep 15, 2025
@@ -0,0 +1,296 @@
# Remove the line below if you want to inherit .editorconfig settings from higher directories
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check pipelines seem to be stuck for a while.

* Add implementations
* Generate help files
* Update metadata
* Update e2e tests
Fix `Get-AzSignalR` and `Remove-AzSignalR` piping following piping guidelines. Originally, it accests piping by value, now it also accepts by property name.
@Y-Sindo
Copy link
Member Author

Y-Sindo commented Sep 15, 2025

/azp run

Copy link
Contributor

Commenter does not have sufficient privileges for PR 28553 in repo Azure/azure-powershell

@VeryEarly
Copy link
Collaborator

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Collaborator

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Collaborator

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Collaborator

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly merged commit c54d08d into Azure:main Sep 17, 2025
12 checks passed
@Y-Sindo Y-Sindo deleted the signalr branch September 17, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants