-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Support custom domain, managed identity for SignalR Service #28553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for custom domains and certificates as well as managed identities for SignalR Service. The changes include both hand-written PowerShell cmdlets for classic SignalR service and auto-generated cmdlets for the newer WebPubSub service.
- Adds new custom certificate and custom domain management cmdlets for SignalR service (New, Get, Remove, Update operations)
- Adds managed identity support for SignalR service creation and updates with both system-assigned and user-assigned identity options
- Updates help documentation and regenerates help files for new and existing cmdlets with the ProgressAction parameter
Reviewed Changes
Copilot reviewed 56 out of 163 changed files in this pull request and generated 9 comments.
Show a summary per file
File | Description |
---|---|
src/SignalR/SignalR/help/*.md |
Regenerated help files with ProgressAction parameter and new cmdlet documentation |
src/SignalR/SignalR/Cmdlets/*CustomDomain*.cs |
New cmdlets for managing custom domains (New, Get, Remove, Update) |
src/SignalR/SignalR/Cmdlets/*CustomCertificate*.cs |
New cmdlets for managing custom certificates (New, Get, Remove) |
src/SignalR/SignalR/Cmdlets/NewAzureRmSignalR.cs |
Added managed identity support with CreateManagedIdentity method |
src/SignalR/SignalR/Cmdlets/UpdateAzureRmSignalR.cs |
Added managed identity update support with UpdateManagedIdentity method |
src/SignalR/SignalR/Models/*.cs |
New model classes for managed identity, custom certificates, and custom domains |
src/SignalR/SignalR/Utilities/Constants.cs |
Added resource type constants for custom domain and certificate child resources |
src/SignalR/SignalR.Test/ScenarioTests/*.ps1/*.cs |
New test scenarios for custom certificate and domain functionality |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ProgressAction parameter documentation contains placeholder text '{{ Fill ProgressAction Description }}' instead of a proper description. This should be replaced with appropriate documentation describing what the ProgressAction parameter does.
{{ Fill ProgressAction Description }} | |
Specifies how the cmdlet responds to progress updates. You can use this parameter to control whether progress information is displayed, suppressed, or handled in a specific way during execution. |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ProgressAction parameter documentation contains placeholder text '{{ Fill ProgressAction Description }}' instead of a proper description. This should be replaced with appropriate documentation describing what the ProgressAction parameter does.
{{ Fill ProgressAction Description }} | |
Specifies how the cmdlet responds to progress updates. The acceptable values for this parameter are: Continue, SilentlyContinue, Stop, Suspend, and Inquire. The default value is None. |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ProgressAction parameter documentation contains placeholder text '{{ Fill ProgressAction Description }}' instead of a proper description. This should be replaced with appropriate documentation describing what the ProgressAction parameter does.
{{ Fill ProgressAction Description }} | |
Specifies how the cmdlet responds to progress updates. The acceptable values for this parameter are: Continue, SilentlyContinue, Stop, and Inquire. |
Copilot uses AI. Check for mistakes.
``` | ||
### -ProgressAction | ||
{{ Fill ProgressAction Description }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ProgressAction parameter documentation contains placeholder text '{{ Fill ProgressAction Description }}' instead of a proper description. This should be replaced with appropriate documentation describing what the ProgressAction parameter does.
{{ Fill ProgressAction Description }} | |
Specifies how the cmdlet responds to progress updates. The acceptable values for this parameter are: Continue, SilentlyContinue, Stop, Suspend, and Inquire. |
Copilot uses AI. Check for mistakes.
``` | ||
### -ProgressAction | ||
{{ Fill ProgressAction Description }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ProgressAction parameter documentation contains placeholder text '{{ Fill ProgressAction Description }}' instead of a proper description. This should be replaced with appropriate documentation describing what the ProgressAction parameter does.
{{ Fill ProgressAction Description }} | |
Specifies how the cmdlet responds to a progress update event. The acceptable values for this parameter are: Continue, SilentlyContinue, Stop, Suspend, and Inquire. By default, progress is displayed in the console. |
Copilot uses AI. Check for mistakes.
``` | ||
### -ProgressAction | ||
{{ Fill ProgressAction Description }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ProgressAction parameter documentation contains placeholder text '{{ Fill ProgressAction Description }}' instead of a proper description. This should be replaced with appropriate documentation describing what the ProgressAction parameter does.
{{ Fill ProgressAction Description }} | |
Specifies how the cmdlet responds to progress updates. The acceptable values for this parameter are: Continue, SilentlyContinue, Stop, Suspend, and Inquire. |
Copilot uses AI. Check for mistakes.
``` | ||
### -ProgressAction | ||
{{ Fill ProgressAction Description }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ProgressAction parameter documentation contains placeholder text '{{ Fill ProgressAction Description }}' instead of a proper description. This should be replaced with appropriate documentation describing what the ProgressAction parameter does.
{{ Fill ProgressAction Description }} | |
Specifies how the cmdlet responds to progress updates. The acceptable values for this parameter are: Continue, SilentlyContinue, Stop, Suspend, and Inquire. |
Copilot uses AI. Check for mistakes.
``` | ||
### -ProgressAction | ||
{{ Fill ProgressAction Description }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ProgressAction parameter documentation contains placeholder text '{{ Fill ProgressAction Description }}' instead of a proper description. This should be replaced with appropriate documentation describing what the ProgressAction parameter does.
{{ Fill ProgressAction Description }} | |
Specifies how the cmdlet responds to progress updates. The acceptable values for this parameter are: Continue, SilentlyContinue, Stop, and Inquire. |
Copilot uses AI. Check for mistakes.
``` | ||
### -ProgressAction | ||
{{ Fill ProgressAction Description }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ProgressAction parameter documentation contains placeholder text '{{ Fill ProgressAction Description }}' instead of a proper description. This should be replaced with appropriate documentation describing what the ProgressAction parameter does.
{{ Fill ProgressAction Description }} | |
Specifies how progress updates are displayed during the execution of the cmdlet. You can use this parameter to control whether progress information is shown, hidden, or handled in a specific way. |
Copilot uses AI. Check for mistakes.
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
src/SignalR/.editorconfig
Outdated
@@ -0,0 +1,296 @@ | |||
# Remove the line below if you want to inherit .editorconfig settings from higher directories |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The check pipelines seem to be stuck for a while.
* Add implementations * Generate help files * Update metadata * Update e2e tests
Fix `Get-AzSignalR` and `Remove-AzSignalR` piping following piping guidelines. Originally, it accests piping by value, now it also accepts by property name.
/azp run |
Commenter does not have sufficient privileges for PR 28553 in repo Azure/azure-powershell |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Description
Support configuring custom certificate, custom domain and managed identity for SignalR Service
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.