Skip to content

Conversation

kamboj-prjwl
Copy link
Member

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings September 15, 2025 04:44
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Azure PowerShell Network module to version 2024-10-01, introducing new functionality for Network Security Perimeter service tags and Application Gateway backend HTTP settings enhancements.

  • Added a new cmdlet Get-AzNetworkSecurityPerimeterServiceTag for retrieving supported service tags
  • Enhanced Application Gateway backend HTTP settings with new SSL/TLS validation properties
  • Updated API specifications from 2024-07-01 to 2024-10-01

Reviewed Changes

Copilot reviewed 19 out of 254 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tools/StaticAnalysis/Exceptions/Az.KeyVault/ExampleIssues.csv Added static analysis exception for Install-Module cmdlet
src/Network/NetworkSecurityPerimeter.Autorest/ (multiple files) Added new cmdlet and documentation for NetworkSecurityPerimeter ServiceTags
src/Network/Network/help/ (multiple files) Updated help documentation for Application Gateway cmdlets with new SSL/TLS parameters
src/Network/Network/Models/PSApplicationGatewayBackendHttpSettings.cs Added new properties for SSL/TLS validation and dedicated connections
src/Network/Network/ApplicationGateway/BackendHttpSettings/AzureApplicationGatewayBackendHttpSettingsBase.cs Implemented new SSL/TLS validation parameters in backend HTTP settings
src/Network/Network/ChangeLog.md Updated changelog with new features
src/Network/Network/Az.Network.psd1 Added new cmdlet to exports and updated module metadata
src/Network/Network.Management.Sdk/README.md Updated API version references from 2024-07-01 to 2024-10-01
src/Network/Network.sln Updated project GUID for NetworkSecurityPerimeter.Autorest

Comment on lines +23 to +25
[-DedicatedBackendConnection <Boolean>] [-ValidateCertChainAndExpiry <Boolean>]
[-ValidateSNI <Boolean>]
[-SniName <String>]
Copy link
Preview

Copilot AI Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The line breaks in the syntax section are inconsistent. Line 23 has parameters on the same line, while lines 24-25 have single parameters. Consider reformatting for consistency, either putting all new parameters on one line or giving each parameter its own line.

Suggested change
[-DedicatedBackendConnection <Boolean>] [-ValidateCertChainAndExpiry <Boolean>]
[-ValidateSNI <Boolean>]
[-SniName <String>]
[-DedicatedBackendConnection <Boolean>]
[-ValidateCertChainAndExpiry <Boolean>]
[-ValidateSNI <Boolean>]
[-SniName <String>]

Copilot uses AI. Check for mistakes.

@@ -20,6 +20,9 @@ New-AzApplicationGatewayBackendHttpSetting -Name <String> -Port <Int32> -Protoco
[-AuthenticationCertificates <PSApplicationGatewayAuthenticationCertificate[]>]
[-TrustedRootCertificate <PSApplicationGatewayTrustedRootCertificate[]>] [-PickHostNameFromBackendAddress]
[-HostName <String>] [-AffinityCookieName <String>] [-Path <String>]
[-DedicatedBackendConnection <Boolean>] [-ValidateCertChainAndExpiry <Boolean>]
Copy link
Preview

Copilot AI Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The line breaks in the syntax section are inconsistent. Line 23 has parameters on the same line, while lines 24-25 have single parameters. Consider reformatting for consistency, either putting all new parameters on one line or giving each parameter its own line.

Suggested change
[-DedicatedBackendConnection <Boolean>] [-ValidateCertChainAndExpiry <Boolean>]
[-DedicatedBackendConnection <Boolean>]
[-ValidateCertChainAndExpiry <Boolean>]

Copilot uses AI. Check for mistakes.

@isra-fel
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@VeryEarly VeryEarly self-assigned this Sep 15, 2025
@VeryEarly VeryEarly added the Do Not Squash 🚫 To prevent conflicts, this PR should not be squash merged. label Sep 15, 2025
Copy link

‼️ Do NOT use squash to merge this pull request. All the commits must be merged to the target branch.
‼️ Enable "Allow merge commits" in the pull request settings. Select "Merge Commits" to merge the PR. Then go back to settings and disable the option.

@isra-fel
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Squash 🚫 To prevent conflicts, this PR should not be squash merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants