corrected devcontainer to work on arm64 computers #28939
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull request overview
This PR aims to improve the devcontainer configuration for Azure PowerShell development by creating a custom Dockerfile and moving setup commands from inline to a dedicated post-create script. However, there is a critical issue: the PR title claims to enable ARM64 support, but the Dockerfile explicitly forces AMD64 architecture, which will cause emulation overhead on ARM64 machines rather than native support.
Key Changes:
- Introduces custom Dockerfile with explicit platform specification
- Moves setup commands to a dedicated
post-create.shscript - Adds additional PowerShell module installations (Az.Accounts)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .devcontainer/Dockerfile | Creates custom Dockerfile that forces AMD64 platform (contradicts PR goal of ARM64 support) |
| .devcontainer/post-create.sh | Extracts setup commands into dedicated script; installs npm, AutoRest, platyPS, and Az.Accounts |
| .devcontainer/devcontainer.json | Updates to use custom Dockerfile and post-create script instead of inline command |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@dolauli , Isolated change for devcontainer, as suggesed in previous PR |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
| @@ -0,0 +1,18 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Could we rewrite this into PowerShell script?
2 participants
Description
Updated devcontainer configuration for Azure PowerShell development
The configuration includes:
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense. not the caseChangeLog.mdif no new release is required, such as fixing test case only.