Skip to content

Conversation

@Samhitha-Microsoft
Copy link
Contributor

@Samhitha-Microsoft Samhitha-Microsoft commented Nov 28, 2025

Description

Previously, the idea was that the user would enable Arc on their own and then trigger registration. But, now due to redefined requirements, we want ARC enablement to be part of the script itself similar to the old way of registration.

Also, There is an issue where access is being denied as there is new session being created in the already existing remote session. Hence, added a flag to prevent creation of new PS session.
image

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copilot AI review requested due to automatic review settings November 28, 2025 12:10
@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request implements automatic Arc enablement as part of the HCI cluster registration flow using Managed Service Identity (MSI). Previously, users were required to manually enable Azure Arc on cluster nodes before triggering registration. This change automates that process by adding Arc enablement logic directly into the registration script.

Key Changes

  • Added new Enable-ArcOnNodes function that installs and configures Azure Connected Machine Agent on cluster nodes
  • Modified Invoke-MSIFlow to automatically enable Arc on nodes if they are not already Arc-enabled
  • Updated ChangeLog.md to document the new Arc enablement behavior

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 10 comments.

File Description
src/StackHCI/StackHCI/ChangeLog.md Added changelog entry for Arc enablement feature (contains formatting and spelling issues)
src/StackHCI/StackHCI.Autorest/custom/stackhci.ps1 Implemented Enable-ArcOnNodes function and integrated it into MSI registration flow (missing parameter definition, lacks documentation and test coverage)

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Copilot AI review requested due to automatic review settings December 1, 2025 02:53
Copilot finished reviewing on behalf of Samhitha-Microsoft December 1, 2025 03:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 11 comments.


You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@isra-fel
Copy link
Member

isra-fel commented Dec 2, 2025

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Samhitha-Microsoft and others added 2 commits December 2, 2025 09:15
Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>
Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>
@isra-fel
Copy link
Member

isra-fel commented Dec 2, 2025

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Copilot AI review requested due to automatic review settings December 2, 2025 04:27
Copilot finished reviewing on behalf of Samhitha-Microsoft December 2, 2025 04:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.


You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@isra-fel
Copy link
Member

isra-fel commented Dec 2, 2025

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants