-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Arc enable nodes before registration in latest Registration Flow #28942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Arc enable nodes before registration in latest Registration Flow #28942
Conversation
…ouble hopon authentication issue
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request implements automatic Arc enablement as part of the HCI cluster registration flow using Managed Service Identity (MSI). Previously, users were required to manually enable Azure Arc on cluster nodes before triggering registration. This change automates that process by adding Arc enablement logic directly into the registration script.
Key Changes
- Added new
Enable-ArcOnNodesfunction that installs and configures Azure Connected Machine Agent on cluster nodes - Modified
Invoke-MSIFlowto automatically enable Arc on nodes if they are not already Arc-enabled - Updated ChangeLog.md to document the new Arc enablement behavior
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 10 comments.
| File | Description |
|---|---|
| src/StackHCI/StackHCI/ChangeLog.md | Added changelog entry for Arc enablement feature (contains formatting and spelling issues) |
| src/StackHCI/StackHCI.Autorest/custom/stackhci.ps1 | Implemented Enable-ArcOnNodes function and integrated it into MSI registration flow (missing parameter definition, lacks documentation and test coverage) |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 11 comments.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>
Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
…/ArcEnableNodesBeforeRegistration
…ps://github.com/Samhitha-Microsoft/azure-powershell into user/samhitham/ArcEnableNodesBeforeRegistration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Description
Previously, the idea was that the user would enable Arc on their own and then trigger registration. But, now due to redefined requirements, we want ARC enablement to be part of the script itself similar to the old way of registration.
Also, There is an issue where access is being denied as there is new session being created in the already existing remote session. Hence, added a flag to prevent creation of new PS session.

Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.