-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Update spec repo #28948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update spec repo #28948
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the StorageSync Management SDK by regenerating code from a newer version of the Azure REST API specifications. The changes involve updating the spec repo commit reference and adjusting the input file path to reflect a reorganized specification structure.
Key changes include:
- Migration from
IEnumerable<T>toIPage<T>return types for list operations to support pagination - Addition of pagination support with "Next" methods for continuing list operations
- Type safety improvements (e.g.,
RetryAfterheader changed fromstringtoint?) - Removal of unused model classes and standardization of parameter/property ordering
- Consistent reordering of validation checks and constructor parameters across generated classes
Reviewed changes
Copilot reviewed 1 out of 80 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updated spec repo commit hash and corrected input file path with new folder structure |
| WorkflowsOperations*.cs | Changed return type to IPage, added pagination methods, reordered validations |
| SyncGroupsOperations*.cs | Changed return type to IPage, added pagination methods, swapped Get/Create method order |
| StorageSyncServicesOperations*.cs | Changed return type to IPage, added pagination methods, reordered methods |
| ServerEndpointsOperations*.cs | Changed return type to IPage, added pagination methods, reordered methods |
| RegisteredServersOperations*.cs | Changed return type to IPage, added pagination methods, parameter documentation updates |
| PrivateEndpointConnectionsOperations*.cs | Changed return type to IPage, added pagination methods, reordered methods |
| PrivateLinkResourcesOperations*.cs | Updated parameter documentation and validation order |
| Operations.cs | Updated operation documentation text |
| StorageSyncManagementClient.cs | Reordered property declarations to match new generation order |
| Header Model Files (50+ files) | Swapped parameter order (xmsCorrelationRequestId before xmsRequestId), changed RetryAfter from string to int? |
| Model Files | Updated StorageSyncService identity documentation, removed 5 unused model classes (SubscriptionState, ResourcesMoveInfo, Reason, ProgressType, OperationDisplayResource, Page1) |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.