Skip to content

Conversation

@ankushbindlish2
Copy link
Member

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copilot AI review requested due to automatic review settings December 3, 2025 06:19
@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the StorageSync Management SDK by regenerating code from a newer version of the Azure REST API specifications. The changes involve updating the spec repo commit reference and adjusting the input file path to reflect a reorganized specification structure.

Key changes include:

  • Migration from IEnumerable<T> to IPage<T> return types for list operations to support pagination
  • Addition of pagination support with "Next" methods for continuing list operations
  • Type safety improvements (e.g., RetryAfter header changed from string to int?)
  • Removal of unused model classes and standardization of parameter/property ordering
  • Consistent reordering of validation checks and constructor parameters across generated classes

Reviewed changes

Copilot reviewed 1 out of 80 changed files in this pull request and generated no comments.

Show a summary per file
File Description
README.md Updated spec repo commit hash and corrected input file path with new folder structure
WorkflowsOperations*.cs Changed return type to IPage, added pagination methods, reordered validations
SyncGroupsOperations*.cs Changed return type to IPage, added pagination methods, swapped Get/Create method order
StorageSyncServicesOperations*.cs Changed return type to IPage, added pagination methods, reordered methods
ServerEndpointsOperations*.cs Changed return type to IPage, added pagination methods, reordered methods
RegisteredServersOperations*.cs Changed return type to IPage, added pagination methods, parameter documentation updates
PrivateEndpointConnectionsOperations*.cs Changed return type to IPage, added pagination methods, reordered methods
PrivateLinkResourcesOperations*.cs Updated parameter documentation and validation order
Operations.cs Updated operation documentation text
StorageSyncManagementClient.cs Reordered property declarations to match new generation order
Header Model Files (50+ files) Swapped parameter order (xmsCorrelationRequestId before xmsRequestId), changed RetryAfter from string to int?
Model Files Updated StorageSyncService identity documentation, removed 5 unused model classes (SubscriptionState, ResourcesMoveInfo, Reason, ProgressType, OperationDisplayResource, Page1)

@isra-fel
Copy link
Member

isra-fel commented Dec 3, 2025

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants