Closed
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades AutoRest to version 4.0.752 and applies the changes to four Azure PowerShell modules: App, PaloAltoNetworks, DynatraceObservability, and EdgeAction. The upgrade adds a ModelCmdletAttribute decorator to auto-generated model cmdlet functions and introduces a new AssemblyInfo.cs file.
Changes:
- Added
[Microsoft.Azure.PowerShell.Cmdlets.App.ModelCmdletAttribute()]attribute to 22 model cmdlet functions in the App module - Introduced a new AssemblyInfo.cs file with assembly metadata for the App.Autorest project
Reviewed changes
Copilot reviewed 23 out of 352 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| New-AzContainerAppWorkloadProfileObject.ps1 | Added ModelCmdletAttribute to function declaration |
| New-AzContainerAppVolumeObject.ps1 | Added ModelCmdletAttribute to function declaration |
| New-AzContainerAppVolumeMountObject.ps1 | Added ModelCmdletAttribute to function declaration |
| New-AzContainerAppTrafficWeightObject.ps1 | Added ModelCmdletAttribute to function declaration |
| New-AzContainerAppTemplateObject.ps1 | Added ModelCmdletAttribute to function declaration |
| New-AzContainerAppServiceBindObject.ps1 | Added ModelCmdletAttribute to function declaration |
| New-AzContainerAppSecretVolumeItemObject.ps1 | Added ModelCmdletAttribute to function declaration |
| New-AzContainerAppSecretObject.ps1 | Added ModelCmdletAttribute to function declaration |
| New-AzContainerAppScaleRuleObject.ps1 | Added ModelCmdletAttribute to function declaration |
| New-AzContainerAppScaleRuleAuthObject.ps1 | Added ModelCmdletAttribute to function declaration |
| New-AzContainerAppRegistryCredentialObject.ps1 | Added ModelCmdletAttribute to function declaration |
| New-AzContainerAppProbeObject.ps1 | Added ModelCmdletAttribute to function declaration |
| New-AzContainerAppProbeHeaderObject.ps1 | Added ModelCmdletAttribute to function declaration |
| New-AzContainerAppJobScaleRuleObject.ps1 | Added ModelCmdletAttribute to function declaration |
| New-AzContainerAppJobExecutionContainerObject.ps1 | Added ModelCmdletAttribute to function declaration |
| New-AzContainerAppInitContainerTemplateObject.ps1 | Added ModelCmdletAttribute to function declaration |
| New-AzContainerAppIdentityProviderObject.ps1 | Added ModelCmdletAttribute to function declaration |
| New-AzContainerAppIPSecurityRestrictionRuleObject.ps1 | Added ModelCmdletAttribute to function declaration |
| New-AzContainerAppEnvironmentVarObject.ps1 | Added ModelCmdletAttribute to function declaration |
| New-AzContainerAppDaprMetadataObject.ps1 | Added ModelCmdletAttribute to function declaration |
| New-AzContainerAppCustomDomainObject.ps1 | Added ModelCmdletAttribute to function declaration |
| New-AzContainerAppConfigurationObject.ps1 | Added ModelCmdletAttribute to function declaration |
| AssemblyInfo.cs | New file with assembly metadata and version information |
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // Code generated by Microsoft (R) AutoRest Code Generator.Changes may cause incorrect behavior and will be lost if the code |
There was a problem hiding this comment.
Missing space after period. Should be 'Code Generator. Changes' instead of 'Code Generator.Changes'.
Suggested change
| // Code generated by Microsoft (R) AutoRest Code Generator.Changes may cause incorrect behavior and will be lost if the code | |
| // Code generated by Microsoft (R) AutoRest Code Generator. Changes may cause incorrect behavior and will be lost if the code |
Comment on lines
+2
to
+7
| // Licensed under the Apache License, Version 2.0 (the ""License""); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an ""AS IS"" BASIS, |
There was a problem hiding this comment.
Corrected escaped double quotes in license header comment from ""License"" to "License".
Suggested change
| // Licensed under the Apache License, Version 2.0 (the ""License""); | |
| // you may not use this file except in compliance with the License. | |
| // You may obtain a copy of the License at | |
| // http://www.apache.org/licenses/LICENSE-2.0 | |
| // Unless required by applicable law or agreed to in writing, software | |
| // distributed under the License is distributed on an ""AS IS"" BASIS, | |
| // Licensed under the Apache License, Version 2.0 (the "License"); | |
| // you may not use this file except in compliance with the License. | |
| // You may obtain a copy of the License at | |
| // http://www.apache.org/licenses/LICENSE-2.0 | |
| // Unless required by applicable law or agreed to in writing, software | |
| // distributed under the License is distributed on an "AS IS" BASIS, |
| @@ -0,0 +1,26 @@ | |||
| // Copyright (c) Microsoft Corporation. All rights reserved. | |||
| // Licensed under the Apache License, Version 2.0 (the ""License""); | |||
| // you may not use this file except in compliance with the License. | |||
There was a problem hiding this comment.
Corrected capitalization of 'License' to maintain consistency with standard Apache 2.0 license text.
Suggested change
| // you may not use this file except in compliance with the License. | |
| // You may not use this file except in compliance with the License. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Autorest Upgrade - 4.0.752 to populate autorest bug fix Azure/autorest.powershell#1540
Modules: App, PaloAltoNetworks, DynatraceObservability, EdgeAction
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.