experiment to add support for wasm32-wasip2 using Spin #2974
+982
−196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces an optional spin feature to enable a Spin-based async runtime and HTTP client when targeting wasm32-wasip2, allowing clients to run in Spin environments. Wires runtime selection to use Spin on wasm with the feature enabled and falls back to existing backends otherwise. Adds workspace dependencies, updates the changelog, and provides VS Code tasks to build the WASI p2 target with Spin. Note: sleep in the Spin runtime is currently a no-op pending stable WASI timing APIs.
- Limits spin dependencies and HTTP client/runtime to wasm32-wasip2 and selects them on WASI. - Excludes reqwest on wasm32-wasip2 while keeping it on other targets. - Auto-enables the spin feature via target-specific dependency in the core crate. - Improves target correctness, avoids incompatible deps, and reduces WASI build surface.
heaths
requested changes
Sep 8, 2025
There was a problem hiding this comment.
I appreciate this is a draft, but I did want to note that we want to avoid adding more "parity features" or even specific implementations to the Azure SDK crates for the same reason: we provide the means to implement HttpClient and AsyncRuntime like you did, but don't want to get into the business of providing countless implementations in the crates for the currently most popular crates. This was the purpose of #2933.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experiment to make targeting wasi32-wasip2 possible. I think the exciting breakthrough will be when wasi32-wasip3 lands with composable concurrency. https://www.fermyon.com/blog/looking-ahead-to-wasip3