-
Notifications
You must be signed in to change notification settings - Fork 312
[Storage] get/set_access_policy
for ContainerClient
#2981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Storage] get/set_access_policy
for ContainerClient
#2981
Conversation
sdk/storage/azure_storage_blob/src/clients/blob_container_client.rs
Outdated
Show resolved
Hide resolved
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Taking a look at the raw logs here, seems like we are running into a recording timestamp mismatch error due to the
In Python we use a get_datetime_variable helper so that those values get taken down as variables in the recording: def get_datetime_variable(self, variables, name, dt):
dt_string = variables.setdefault(name, dt.isoformat())
return datetime.strptime(dt_string, "%Y-%m-%dT%H:%M:%S.%f") "Variables": {
"if_modified": "2022-07-13T23:29:50.814080"
} @heaths Heath, is this something that would be considered in |
At least for JSON - we could see about adding XML support, if we don't have it already - you can pass a custom matcher. In our root CONTRIBUTING.md, we link to https://github.com/Azure/azure-sdk-for-rust/blob/main/sdk/core/azure_core_test/README.md that goes into detail. This is the same test-proxy we use in all our Azure SDK languages. So whatever you've done in other languages you could do here as well. |
And we already have support to read and store recorded variables if that's easier. You can pass whatever you want to that or even wrap it for ease if you want. |
How do you store recorded variables in Rust? In the current recording configuration in Rust (to my knowledge) |
TODO
.tsp
Changes: