Add RawResponse to ErrorKind::HttpResponse
#2983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renames `RawResponse` to `BufResponse` - inspired by `std::io::BufReader`, and adds a new `RawResponse` where the body is fully read and stored in `Bytes`. Refactored `Headers` and other types necessary to add `RawResponse` to `ErrorKind::HttpResponse`. Fixes Azure#2962 Fixes Azure#2495 Relates to Azure#2725 Relates to Azure#1995
heaths
requested review from
RickWinter,
vincenttran-msft,
jalauzon-msft,
a team,
chlowell and
ronniegeraghty
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR renames RawResponse to BufResponse and introduces a new RawResponse type that stores the complete response body as Bytes. The new RawResponse is added to ErrorKind::HttpResponse to provide better error context. Additionally, it refactors Headers and other HTTP-related types to support this change.
- Renamed
RawResponsetoBufResponsethroughout the codebase to reflect its streaming nature - Added new
RawResponsethat contains the complete response body asBytes - Enhanced
ErrorKind::HttpResponseto include the newRawResponsefor better error diagnostics
Reviewed Changes
Copilot reviewed 63 out of 70 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/typespec/src/error/mod.rs | Added raw_response field to ErrorKind::HttpResponse and updated constructors |
| sdk/typespec/src/http/response.rs | Added new RawResponse struct with complete body as Bytes |
| sdk/typespec/typespec_client_core/src/http/response.rs | Renamed RawResponse to BufResponse and added conversion method |
| sdk/typespec/typespec_client_core/src/http/headers/mod.rs | Moved header types to typespec crate |
| Multiple client files | Updated imports and type references from RawResponse to BufResponse |
github-actions
bot
added
Azure.Core
github-project-automation
bot
added this to
Azure SDK for Key Vault and Azure Identity SDK Improvements
github-project-automation
bot
moved this to Untriaged
in Azure Identity SDK Improvements
LarryOsterman
approved these changes
Sep 10, 2025
sdk/keyvault/azure_security_keyvault_certificates/src/generated/clients/certificate_client.rs
Show resolved
Hide resolved
LarryOsterman
approved these changes
Sep 10, 2025
github-project-automation
bot
moved this from Untriaged
to Done
in Azure SDK for Key Vault
github-project-automation
bot
moved this from Untriaged
to Done
in Azure Identity SDK Improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames
RawResponsetoBufResponse- inspired bystd::io::BufReader, and adds a newRawResponsewhere the body is fully read and stored inBytes.Refactored
Headersand other types necessary to addRawResponsetoErrorKind::HttpResponse.Fixes #2962
Fixes #2495
Relates to #2725
Relates to #1995