Skip to content

Fix bug on building command #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mjy9088 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix bug on building command #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2eed1da
Fix bug: avoid shell interpolation in exec by passing args array
mjy9088 Sep 18, 2025
71555b9
Fix bug: incorrect az usage
mjy9088 Sep 19, 2025
306a558
Build dist
mjy9088 Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions azurecontainerapps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,9 +428,7 @@ export class azurecontainerapps {
// Get the build arguments to pass to the Dockerfile or builder
let buildArguments: string[] = [];
if (!this.util.isNullOrEmpty(this.buildArguments)) {
this.buildArguments.match(buildArgumentRegex).forEach((buildArg) => {
buildArguments.push(buildArg);
});
buildArguments = this.buildArguments.match(buildArgumentRegex);
}

// Get Dockerfile to build, if provided, or check if one exists at the root of the provided application
Expand Down Expand Up @@ -507,9 +505,7 @@ export class azurecontainerapps {

// Add user-specified build environment variables
if (buildArguments.length > 0) {
buildArguments.forEach((buildArg) => {
environmentVariables.push(buildArg);
});
environmentVariables.push(...buildArguments);
}

this.toolHelper.writeInfo(`Building image "${imageToBuild}" using the Oryx++ Builder`);
Expand Down Expand Up @@ -614,16 +610,16 @@ export class azurecontainerapps {
}
}

const environmentVariables: string = this.toolHelper.getInput('environmentVariables', false);
const environmentVariables = this.toolHelper.getInput('environmentVariables', false).split(/\s+/g).filter(Boolean);
const isCappUpdateCommandUsed: boolean = this.noIngressUpdate || (!this.noIngressUpdate && !this.adminCredentialsProvided)
// Add user-specified environment variables
if (!this.util.isNullOrEmpty(environmentVariables)) {
if (environmentVariables.length) {
// The --replace-env-vars flag is only used for the 'update' command,
// otherwise --env-vars is used for 'create' and 'up'
if (isCappUpdateCommandUsed) {
this.commandLineArgs.push(`--replace-env-vars ${environmentVariables}`);
this.commandLineArgs.push('--replace-env-vars', ...environmentVariables);
} else {
this.commandLineArgs.push(`--env-vars ${environmentVariables}`);
this.commandLineArgs.push('--set-env-vars', ...environmentVariables);
}
}

Expand Down
Loading