[eno] Cherry-pick changes to eno release branch v0.2.x #556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
op is dereferenced for the log line but it can be nil. Splitting the if
block into two as it seemed that the log line "concurrency limit
reached" does not apply to the case when op is nil.
Example error:
```
[pod/eno-controller-7459646c9-bdctm/eno-controller] {"level":"error","ts":1767623387.6310673,"caller":"runtime/runtime.go:142","msg":"Observed a panic","controller":"schedulingController","reconcileID":"bbaa832f-8868-4f5b-bac8-efe20e8b50ab","panic":"runtime error: invalid memory address or nil pointer dereference","panicGoValue":"\"invalid memory address or nil pointer dereference\"","stacktrace":"goroutine 328 [running]:\nk8s.io/apimachinery/pkg/util/runtime.logPanic({0x1cfe328, 0xc000617b90}, {0x17a8ba0, 0x28ee950})\n\t/go/pkg/mod/k8s.io/apimachinery@v0.34.0/pkg/util/runtime/runtime.go:132 +0xbc\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Reconcile.func1()\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.22.0/pkg/internal/controller/controller.go:198 +0x10e\npanic({0x17a8ba0?, 0x28ee950?})\n\t/usr/local/go/src/runtime/panic.go:792 +0x132\ngithub.com/Azure/eno/internal/controllers/scheduling.(*controller).Reconcile(0xc0005ab0c0, {0x1cfe328, 0xc000617b90}, {{{0x100?, 0xc000378008?}, {0xc0001cdd80?, 0x0?}}})\n\t/app/internal/controllers/scheduling/controller.go:141 +0xeed\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Reconcile(0xc000617ad0?, {0x1cfe328?, 0xc000617b90}, {{{0x0, 0x0?}, {0x0?, 0x0?}}})\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.22.0/pkg/internal/controller/controller.go:216 +0x165\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).reconcileHandler(0x1d1c3c0, {0x1cfe360, 0xc00047dbd0}, {{{0x0, 0x0}, {0x0, 0x0}}}, 0x0)\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.22.0/pkg/internal/controller/controller.go:461 +0x3ad\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).processNextWorkItem(0x1d1c3c0, {0x1cfe360, 0xc00047dbd0})\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.22.0/pkg/internal/controller/controller.go:421 +0x21b\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Start.func1.1()\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.22.0/pkg/internal/controller/controller.go:296 +0x85\ncreated by sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Start.func1 in goroutine 209\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.22.0/pkg/internal/controller/controller.go:292 +0x26b\n","stacktrace":"k8s.io/apimachinery/pkg/util/runtime.logPanic\n\t/go/pkg/mod/k8s.io/apimachinery@v0.34.0/pkg/util/runtime/runtime.go:142\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Reconcile.func1\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.22.0/pkg/internal/controller/controller.go:198\nruntime.gopanic\n\t/usr/local/go/src/runtime/panic.go:792\nruntime.panicmem\n\t/usr/local/go/src/runtime/panic.go:262\nruntime.sigpanic\n\t/usr/local/go/src/runtime/signal_unix.go:925\ngithub.com/Azure/eno/internal/controllers/scheduling.(*controller).Reconcile\n\t/app/internal/controllers/scheduling/controller.go:141\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Reconcile\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.22.0/pkg/internal/controller/controller.go:216\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.22.0/pkg/internal/controller/controller.go:461\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.22.0/pkg/internal/controller/controller.go:421\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Start.func1.1\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.22.0/pkg/internal/controller/controller.go:296"}
```
Co-authored-by: Yunus Inci <yinci@microsoft.com>
- Only migrate `f:metadata:annotation`, `f:metadata:labels`, and `f:spec` during the migration. Tested e2e pipeline passed: https://msazure.visualstudio.com/CloudNativeCompute/_build/results?buildId=149448228&view=results https://msazure.visualstudio.com/CloudNativeCompute/_build/results?buildId=149448289&view=results https://msazure.visualstudio.com/CloudNativeCompute/_build/results?buildId=149448264&view=results https://msazure.visualstudio.com/CloudNativeCompute/_build/results?buildId=149448364&view=results https://msazure.visualstudio.com/CloudNativeCompute/_build/results?buildId=149448306&view=results https://msazure.visualstudio.com/CloudNativeCompute/_build/results?buildId=149449489&view=results https://dev.azure.com/msazure/CloudNativeCompute/_build/results?buildId=149448405&view=results
ruinan-liu
changed the title
tilnl
approved these changes
Jan 15, 2026
xiazhan
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picking below 2 commits to release branch