Makes FetchEventSource compatible with webworker #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- when openWhenHidden is true, the event listener is not added. So don't remove it in dispose(). This helps the webworker use case where document does not exist, but can be worked around by setting openWhenHidden to true.
- self will work in both browser window and webworker context
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
these changes (somehow similar to #8) are the minimal ones I had to do to get FetchEventSource working in a web worker context.
I've also added some unit tests to validate these changes.
With it one can use FetchEventSource in a WebWorker by settings these parameters :