Skip to content
This repository was archived by the owner on Feb 18, 2021. It is now read-only.

better way to use setstate avoiding sideeffects #397

Open
gusbueno wants to merge 1 commit into
base: master
Choose a base branch
from
Open

better way to use setstate avoiding sideeffects #397

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 25 additions & 22 deletions client/src/components/Dashboard/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,8 @@ export default class Dashboard extends React.Component<IDashboardProps, IDashboa
layouts = _.extend(layouts, dashboard.layouts || {});

this.layouts = layouts;
this.setState({
this.setState(state => ({
...state,
mounted: true,
layouts: { lg: layouts['lg'] },
grid: {
Expand All @@ -128,7 +129,7 @@ export default class Dashboard extends React.Component<IDashboardProps, IDashboa
breakpoints: layout.breakpoints,
verticalCompact: false
}
});
}));
}
}

Expand All @@ -142,16 +143,17 @@ export default class Dashboard extends React.Component<IDashboardProps, IDashboa
}

onVisibilityStoreChange(state: any) {
this.setState({ visibilityFlags: state.flags });
this.setState(state => ({ ...state, visibilityFlags: state.flags }));
}

onBreakpointChange(breakpoint: any) {
var layouts = this.state.layouts;
layouts[breakpoint] = layouts[breakpoint] || this.layouts[breakpoint];
this.setState({
this.setState(state => ({
...state,
currentBreakpoint: breakpoint,
layouts: layouts
});
}));
}

onLayoutChange(layout: any, layouts: any) { }
Expand All @@ -162,9 +164,10 @@ export default class Dashboard extends React.Component<IDashboardProps, IDashboa
let breakpoint = this.state.currentBreakpoint;
let newLayouts = this.state.layouts;
newLayouts[breakpoint] = layout;
this.setState({
this.setState(state => ({
...state,
layouts: newLayouts
});
}));

// Saving layout to API
let { dashboard } = this.props;
Expand All @@ -180,19 +183,19 @@ export default class Dashboard extends React.Component<IDashboardProps, IDashboa
}

onConfigDashboard() {
this.setState({ askConfig: true });
this.setState(state => ({ ...state, askConfig: true }));
}

toggleEditMode() {
this.setState({ editMode: !this.state.editMode });
this.setState(state => ({ ...state, editMode: !this.state.editMode }));
}

onDeleteDashboard() {
this.setState({ askDelete: true });
this.setState(state => ({ ...state, askDelete: true }));
}

onSaveAsTemplate() {
this.setState({ askSaveAsTemplate: true });
this.setState(state => ({ ...state, askSaveAsTemplate: true }));
}

onSaveAsTemplateApprove() {
Expand All @@ -208,19 +211,19 @@ export default class Dashboard extends React.Component<IDashboardProps, IDashboa

ConfigurationsActions.saveAsTemplate(template);
window.location.href = '/';
this.setState({ askSaveAsTemplate: false });
this.setState(state => ({ ...state, askSaveAsTemplate: false }));
}

onSaveAsTemplateCancel() {
this.setState({ askSaveAsTemplate: false });
this.setState(state => ({ ...state, askSaveAsTemplate: false }));
}

newTemplateNameChange(value: string, e: any) {
this.setState({ newTemplateName: value });
this.setState(state => ({ ...state, newTemplateName: value }));
}

newTemplateDescriptionChange(value: string, e: any) {
this.setState({ newTemplateDescription: value });
this.setState(state => ({ ...state, newTemplateDescription: value }));
}

onDeleteDashboardApprove() {
Expand All @@ -230,28 +233,28 @@ export default class Dashboard extends React.Component<IDashboardProps, IDashboa
}
ConfigurationsActions.deleteDashboard(dashboard.id);
window.location.href = '/';
this.setState({ askDelete: false });
this.setState(state => ({ ...state, askDelete: false }));
}

onDeleteDashboardCancel() {
this.setState({ askDelete: false });
this.setState(state => ({ ...state, askDelete: false }));
}

onConfigDashboardCancel() {
this.setState({ askConfig: false });
this.setState(state => ({ ...state, askConfig: false }));
}

onUpdateLayout() {
this.setState({ editMode: !this.state.editMode });
this.setState({ editMode: !this.state.editMode });
this.setState(state => ({ ...state, editMode: !this.state.editMode }));
this.setState(state => ({ ...state, editMode: !this.state.editMode }));
}

onOpenInfo(html: string) {
this.setState({ infoVisible: true, infoHtml: html });
this.setState(state => ({ ...state, infoVisible: true, infoHtml: html }));
}

onCloseInfo() {
this.setState({ infoVisible: false });
this.setState(state => ({ ...state, infoVisible: false }));
}

onDownloadDashboard() {
Expand Down