Enhance artifact loading functions to support artifact name annotations on the layer matching ORAS functionality.#26
Closed
JeromySt wants to merge 2 commits intoAzure:mainfrom
Conversation
…ns on the layer matching ORAS functionality.
…ons and improve test coverage for filename handling
JeromySt
requested review from
AndreHamilton-MSFT,
bbishopMSFT,
ridhoq and
sajayantony
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comparing artifacts uploaded to ACR using ORAS and OBOM has shown a discrepancy in that ORAS properly sets the filename annotation on the layer, while OBOM does not. This causes issues when attempting to differentiate between different types of SPDX content files or SBOMs based on naming conventions etc.
This PR bring parity between ORAS and OBOM in a backwards compatible way, but default new artifacts get created with the title annotation on the layer properly added.