Conversation
|
several questions:
|
525fa0f to
2c968d6
Compare
|
If we want to maintain support for the track 1 skewer module as well, it would be best to either create a If we decide to drop support for track 1, merging to main would be fine. |
Answers below in my opinion:
|
matthchr
left a comment
There was a problem hiding this comment.
Had few more comments, but overall LGTM and probably at this point reasonable to move to v2 subfolder?
|
move the files to new folder v2. |
add v2 folder, which uses the latest version of Azure SDK for Go (known as track2), as old version of Azure SDK for go (known as track1) is deprecated and no longer recieving support.
The v2 folder looks like a standalone package, which also uses package name skewer, only shares go.mod and go.sum with current package. check the usage in v2/README.md or v2/example/example.go
I copied the original go codes to v2 and refactored on it. keep most old codes and only work on necessary changes:
armcompute.ResourceSKUsClientinstead ofcompute.ResourceSkusClient, ininterface.go,client.go,cache.goarmcompute.ResourceSKUinstead ofcompute.ResourceSku, insku.go,wrap.goas track2 List returns []* instead of [], and some properties use []* instead of *[], I changed some usages (for example, nil check) of those models.
I don't change SKU here, so SKU is not pointer and data is still []SKU but not []*armcompute.ResourceSKU, which might be different from sdk pattern.
golangci-lint run --fixmight give some lint issues. as the linter settings are so old and even fail for main branch, I don't fix them.