fix: address inconsistencies in SKU property case-sensitivity string checks#31
Merged
matthchr merged 2 commits intoAzure:mainfrom Nov 14, 2025
Merged
Conversation
Contributor
|
in (v1) sku.go restriction.Type (line 349,373,476,539) and func MemberOf (line 579), |
Contributor
Author
|
Pushed a comment to add a case-insensitive check for the // ResourceSKURestrictionsType - The type of restrictions.
type ResourceSKURestrictionsType string
const (
ResourceSKURestrictionsTypeLocation ResourceSKURestrictionsType = "Location"
ResourceSKURestrictionsTypeZone ResourceSKURestrictionsType = "Zone"
) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses inconsistencies in case-sensitivity when matching SKU capabilities. Previously, some functions used case-sensitive string matches whilst other functions used case-insensitive matches for SKU capability names.