[tcgc] add stream metadata #3867
Conversation
iscai-msft
requested review from
bterlson,
joheredi,
lmazuel,
m-nash,
markcowl,
srnagar and
timotheeguerin
as code owners
microsoft-github-policy-service
bot
added
the
lib:tcgc
|
All changed packages have been documented.
Show changes
|
commit: |
|
You can try these changes here
|
| ): [SdkStreamMetadata, readonly Diagnostic[]] { | ||
| const diagnostics = createDiagnosticCollector(); | ||
| const bodyType = diagnostics.pipe( | ||
| getClientTypeWithDiagnostics(context, tspStreamMetadata.bodyType, operation), |
There was a problem hiding this comment.
I'm just wondering if these stream models need usage flag?
There was a problem hiding this comment.
ooh, that's a very good point. I think we want it just for .streamType, since that's what emitters need to gxenerate deserialization / serialization code. So it should be input / output. The question is if we need json for it. I think yes, but also the json flag was added for how csharp serializes json models, so not sure how applicable that would be in the streaming scenario. I think from a pure tcgc standpoint though, the json usage makes sense though
There was a problem hiding this comment.
I also updated access for the stream type based off of the operation, might be a bit unnecessary, but I figure why not
3 participants
fixes #3862