Skip to content

Get AAD Device Id API for resource account, Fixes AB#3275226 #2644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

mohitc1
Copy link
Contributor

@mohitc1 mohitc1 commented May 16, 2025

Copy link

✅ Work item link check complete. Description contains link AB#3275226 to an Azure Boards work item.

Copy link

❌ Work item link check failed. Description contains AB#3275226 but the Bot could not link it to an Azure Boards work item.

Click here to learn more.

@github-actions github-actions bot changed the title Get AAD Device Id API for resource account Get AAD Device Id API for resource account, Fixes AB#3275226 May 16, 2025
@mohitc1 mohitc1 marked this pull request as ready for review May 16, 2025 15:46
@mohitc1 mohitc1 requested review from a team as code owners May 16, 2025 15:46
@mohitc1 mohitc1 requested a review from Copilot May 16, 2025 17:30
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for fetching an AAD Device Id for resource accounts through the broker, addressing AB#3275226. Key changes include:

  • Added a new DTO (AadDeviceIdRecord) and corresponding command parameters (GetAadDeviceIdCommandParameters) to represent and request the device id.
  • Extended the BrokerRequest/BrokerResult handling and Controller logic to support the new Get AAD Device Id API.
  • Introduced tests for validating the implementation across request building and result parsing.

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
common4j/src/main/com/microsoft/identity/common/java/dto/AadDeviceIdRecord.kt Introduces the new DTO for AAD device id records
common4j/src/main/com/microsoft/identity/common/java/commands/parameters/GetAadDeviceIdCommandParameters.java Adds command parameters to request the AAD device id
common/src/test/java/com/microsoft/identity/common/internal/request/MsalBrokerResultAdapterTests.kt Adds tests for AadDeviceIdRecord extraction
common/src/test/java/com/microsoft/identity/common/internal/request/MsalBrokerRequestAdapterTests.java Adds tests for building the request bundle for AAD device id requests
common/src/main/java/com/microsoft/identity/common/internal/result/MsalBrokerResultAdapter.java Extends BrokerResult parsing to extract AadDeviceIdRecord
common/src/main/java/com/microsoft/identity/common/internal/request/MsalBrokerRequestAdapter.java Adds request bundle creation method for AAD device id requests
common/src/main/java/com/microsoft/identity/common/internal/controllers/BrokerMsalController.java Includes a new controller method to retrieve the AAD device id
common/src/main/java/com/microsoft/identity/common/internal/broker/ipc/BrokerOperationBundle.java Adds a new enum entry for the GET_AAD_DEVICE_ID operation
common/src/main/java/com/microsoft/identity/common/internal/broker/BrokerResult.java Updates BrokerResult to encapsulate an AadDeviceIdRecord
common/src/main/java/com/microsoft/identity/common/internal/broker/BrokerRequest.java Updates BrokerRequest to include tenant id for device id requests
common/src/main/java/com/microsoft/identity/common/adal/internal/AuthenticationConstants.java Adds a constant for the GET_AAD_DEVICE_ID broker path
changelog.txt Documents the addition of the new Get AAD Device ID API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant