-
Notifications
You must be signed in to change notification settings - Fork 36
Get AAD Device Id API for resource account, Fixes AB#3275226 #2644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
✅ Work item link check complete. Description contains link AB#3275226 to an Azure Boards work item. |
❌ Work item link check failed. Description contains AB#3275226 but the Bot could not link it to an Azure Boards work item. Click here to learn more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for fetching an AAD Device Id for resource accounts through the broker, addressing AB#3275226. Key changes include:
- Added a new DTO (AadDeviceIdRecord) and corresponding command parameters (GetAadDeviceIdCommandParameters) to represent and request the device id.
- Extended the BrokerRequest/BrokerResult handling and Controller logic to support the new Get AAD Device Id API.
- Introduced tests for validating the implementation across request building and result parsing.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
common4j/src/main/com/microsoft/identity/common/java/dto/AadDeviceIdRecord.kt | Introduces the new DTO for AAD device id records |
common4j/src/main/com/microsoft/identity/common/java/commands/parameters/GetAadDeviceIdCommandParameters.java | Adds command parameters to request the AAD device id |
common/src/test/java/com/microsoft/identity/common/internal/request/MsalBrokerResultAdapterTests.kt | Adds tests for AadDeviceIdRecord extraction |
common/src/test/java/com/microsoft/identity/common/internal/request/MsalBrokerRequestAdapterTests.java | Adds tests for building the request bundle for AAD device id requests |
common/src/main/java/com/microsoft/identity/common/internal/result/MsalBrokerResultAdapter.java | Extends BrokerResult parsing to extract AadDeviceIdRecord |
common/src/main/java/com/microsoft/identity/common/internal/request/MsalBrokerRequestAdapter.java | Adds request bundle creation method for AAD device id requests |
common/src/main/java/com/microsoft/identity/common/internal/controllers/BrokerMsalController.java | Includes a new controller method to retrieve the AAD device id |
common/src/main/java/com/microsoft/identity/common/internal/broker/ipc/BrokerOperationBundle.java | Adds a new enum entry for the GET_AAD_DEVICE_ID operation |
common/src/main/java/com/microsoft/identity/common/internal/broker/BrokerResult.java | Updates BrokerResult to encapsulate an AadDeviceIdRecord |
common/src/main/java/com/microsoft/identity/common/internal/broker/BrokerRequest.java | Updates BrokerRequest to include tenant id for device id requests |
common/src/main/java/com/microsoft/identity/common/adal/internal/AuthenticationConstants.java | Adds a constant for the GET_AAD_DEVICE_ID broker path |
changelog.txt | Documents the addition of the new Get AAD Device ID API |
Fixes AB#3275226
Refer https://github.com/AzureAD/ad-accounts-for-android/pull/3096