Skip to content

Implementing IDisposable interface for PersistentVM class as it is causi... #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
v-didara wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Implementing IDisposable interface for PersistentVM class as it is causi... #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion src/ServiceManagement/Compute/Commands.ServiceManagement/Model/PersistentVM.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,15 @@
// limitations under the License.
// ----------------------------------------------------------------------------------

using System;
using System.Collections.Generic;
using System.Collections.ObjectModel;
using System.Security.Cryptography.X509Certificates;
using System.Xml.Serialization;

namespace Microsoft.WindowsAzure.Commands.ServiceManagement.Model
{
public class PersistentVM : IPersistentVM
public class PersistentVM : IPersistentVM,IDisposable
Copy link
Copy Markdown
Collaborator

@huangpf huangpf Nov 7, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a space after the comma.

{
public string AvailabilitySetName
{
Expand Down Expand Up @@ -131,6 +132,33 @@ public PersistentVM GetInstance()
{
return this;
}

public void Dispose()
{
Dispose(true);
GC.SuppressFinalize(this);
}

protected virtual void Dispose(bool disposing)
{
if (disposing)
{
//Free managed resources
ResourceExtensionReferences = null;
DataVirtualHardDisksToBeDeleted = null;
X509Certificates = null;
WinRMCertificate = null;
ConfigurationSets = null;
DataVirtualHardDisks = null;
OSVirtualHardDisk = null;
}
//Free unmanaged resources
}

~PersistentVM()
{
Dispose(false);
}
}
}