Skip to content

Feature: Add Tiled#153

Draft
ravescovi wants to merge 2 commits intomainfrom
add-tiled
Draft

Feature: Add Tiled#153
ravescovi wants to merge 2 commits intomainfrom
add-tiled

Conversation

@ravescovi
Copy link
Contributor

Description

Adding tiled functionalities into BITS

Type of change

  • New feature (non-breaking change that adds functionality)
  • Documentation update

@ravescovi ravescovi self-assigned this Jun 4, 2025
@ravescovi ravescovi added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 4, 2025
"caproto",
"databroker ==1.2.5",
"databroker",
"tiled[server]",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider pinning the tiled version. It's still beta, and new releases sometimes break my setup.

@prjemian prjemian self-requested a review June 5, 2025 00:04
@ravescovi
Copy link
Contributor Author

ravescovi commented Jun 5, 2025 via email

@canismarko
Copy link
Collaborator

Any particular stable version? I will lock to the same as yours.

There's not really a stable version since it's still beta. We're using 0.1.0-b28 in production for the server right now (the production environment is using the branch in that PR).

For the client, we're still using 0.1.0-b27, but I have a PR open to update this.

@MDecarabas
Copy link
Collaborator

@prjemian. Food for thought for what you're looking into

@prjemian
Copy link
Collaborator

prjemian commented Jul 8, 2025

I'm working with the latest from Pypi: ...b29

@canismarko
Copy link
Collaborator

I'm working with the latest from Pypi: ...b29

Spectroscopy group is using b29 for client and server as well.

- docs/tiled/: Documentation for tiled integration
- src/apsbits/demo_tiled/: Demo tiled server scripts and configuration
- Provides example tiled server setup and management scripts
Copy link
Collaborator

@prjemian prjemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR copies code from other repositories. On each file hoisted from other repos, cite the source.

Remove parts that are only examples, especially those that are applicable only in the original context.

Focus the PR on the addition of tiled client configuration for BITS. Separate the tiled server configuration. If, after this PR is merged, then propose a tiled server configuration in a new branch & PR.

Every line of AI-generated code must be reviewed and tested to work correctly by the human contributor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants