Skip to content

MNT remove redundant code; see init_catalog()#191

Open
prjemian wants to merge 2 commits intomainfrom
cleanup-for-tiled
Open

MNT remove redundant code; see init_catalog()#191
prjemian wants to merge 2 commits intomainfrom
cleanup-for-tiled

Conversation

@prjemian
Copy link
Collaborator

The tiled_client is not used in startup.py now. This is handled by apsbits.core.init_catalog() now.

@prjemian prjemian requested a review from MDecarabas January 15, 2026 21:10
@prjemian prjemian self-assigned this Jan 15, 2026
@coveralls
Copy link

Pull Request Test Coverage Report for Build 21046559579

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 84.507%

Totals Coverage Status
Change from base Build 20969680449: 0.08%
Covered Lines: 1440
Relevant Lines: 1704

💛 - Coveralls

Copy link
Collaborator

@MDecarabas MDecarabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please add more documentation for what to place where in the iconfig so that tiled will function.

@prjemian
Copy link
Collaborator Author

Sure, I can add. Where would you recommend the new content? Perhaps docs/source/guides/setting_iconfig.rst? Other places (under docs/source/) might need updates for this shift from databroker to tiled.

@MDecarabas
Copy link
Collaborator

setting_iconfig sound great

@prjemian
Copy link
Collaborator Author

I'm not making any changes to demo_scripts/qs_host.sh.

@MDecarabas
Copy link
Collaborator

I'm not making any changes to demo_scripts/qs_host.sh.

?

@prjemian
Copy link
Collaborator Author

I'm not making any changes to demo_scripts/qs_host.sh.

These lines:

if [ "${DATABROKER_CATALOG}" == "" ]; then
if [ -f "${ICONFIG_YML}" ]; then
DATABROKER_CATALOG=$(grep DATABROKER_CATALOG "${ICONFIG_YML}" | awk '{print $NF}')
# echo "Using catalog ${DATABROKER_CATALOG}"
fi
fi
DEFAULT_SESSION_NAME="bluesky_queueserver-${DATABROKER_CATALOG}"

@MDecarabas
Copy link
Collaborator

I see, I didn't remember this snippet. Now that you bring it up, shouldn't we. Isn't the goal to move towards tiled servers for the qs as well. At the very least have a conditional that if data broker is not defined try tiled, and if that is not defined either start a local temp tiled server?

prjemian added a commit that referenced this pull request Jan 21, 2026
prjemian added a commit that referenced this pull request Jan 21, 2026
@prjemian
Copy link
Collaborator Author

Turns out this is easier than anticipated.

prjemian added a commit that referenced this pull request Jan 21, 2026
prjemian added a commit that referenced this pull request Jan 21, 2026
prjemian added a commit that referenced this pull request Jan 21, 2026
@prjemian
Copy link
Collaborator Author

@MDecarabas Take another look now.

  • Docs added to the file described above.
  • Bash script qs_host.sh updated to consider TILED_PROFILE_NAME.
  • Pre-commit run enough times that it stopped complaining.

@MDecarabas MDecarabas self-requested a review January 21, 2026 20:44
prjemian added a commit that referenced this pull request Jan 21, 2026
prjemian added a commit that referenced this pull request Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants