Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[refactor] 관리자 페이지 리디자인 반영 #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
[refactor] 관리자 페이지 리디자인 반영 #187
Changes from all commits
689b846be6c706829161ce0fe47aFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
manager변형이 터치/키보드 접근성을 너무 줄입니다.이 분기에서는 실제 클릭 영역이
20x37정도로 작아지고focus-visible표시도 사라집니다. 모바일 WebView에서는 누르기 어렵고, 키보드 포커스도 보이지 않아서 시각적인 트랙은 유지하더라도 버튼 hit area와 포커스 링은 따로 확보하는 편이 좋습니다.As per coding guidelines,
src/components/**: React 컴포넌트 컨벤션을 확인해주세요: - 접근성(aria-*, role, 키보드 탐색)이 적절히 처리되는지.🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
지원자 목록 페이지 타이틀이 빠져 있습니다.
src/App.tsx에는/mypage/manager/:clubId/applications라우트가 있는데 여기엔 매칭이 없습니다. 지금headerConfig.ts가 manager 하위 경로 전체를 manager 헤더로 잡고 있어서, 이 페이지는 빈 제목으로 렌더링됩니다.수정 예시
{ + match: (pathname) => /^\/mypage\/manager\/\d+\/applications$/.test(pathname), + title: '지원자 관리', + }, + { match: (pathname) => /^\/mypage\/manager\/\d+\/applications\/\d+$/.test(pathname), title: '지원서 보기', },🤖 Prompt for AI Agents
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.