Add default ruleset and add properties.json #3
Conversation
bio-boris
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR adds configuration files for repository management and workflow templates. It introduces a default ruleset for branch protection and a properties file for Docker image build workflow templates.
- Creates a comprehensive default ruleset with branch protection rules
- Adds workflow template properties for Docker image building
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| workflow-templates/build_docker_image.properties.json | Adds metadata for Docker image build workflow template |
| default_berdl_ruleset.json | Defines default branch protection ruleset with PR requirements and status checks |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| { | ||
| "type": "pull_request", | ||
| "parameters": { | ||
| "required_approving_review_count": 0, |
There was a problem hiding this comment.
Setting required_approving_review_count to 0 means pull requests can be merged without any code review approvals, which poses a security risk for protected branches like main and develop.
| "required_approving_review_count": 0, | |
| "required_approving_review_count": 1, |
| "parameters": { | ||
| "required_approving_review_count": 0, | ||
| "dismiss_stale_reviews_on_push": false, | ||
| "require_code_owner_review": false, |
There was a problem hiding this comment.
Disabling code owner review requirement means changes to critical files can be merged without oversight from designated code owners, reducing code quality and security controls.
| "require_code_owner_review": false, | |
| "require_code_owner_review": true, |
No description provided.